Update FLINT to 2.4.1 #15574

jpflori · 2013-12-23T14:45:59Z

FLINT 2.4.1 has been released:

http://www.flintlib.org/news.html

The update should be quite trivial.

Use git branch and vanilla upstream tarball at:

http://boxen.math.washington.edu/home/jpflori/upstream/flint-2.4.1.tar.gz
(or at http://flintlib.org)

CC: @defeo

Component: packages: standard

Keywords: flint spkg

Author: Jean-Pierre Flori

Branch/Commit: u/jpflori/ticket/15574 @ 5271eca

Reviewer: François Bissey, Luca De Feo

Issue created by migration from https://trac.sagemath.org/ticket/15574

The text was updated successfully, but these errors were encountered:

jpflori · 2013-12-24T00:14:55Z

Commit: 2a2f3c9

jpflori · 2013-12-24T00:14:55Z

Changed keywords from none to flint spkg

jpflori · 2013-12-24T00:14:55Z

Branch: u/jpflori/ticket/15574

jpflori · 2013-12-24T00:14:55Z

comment:2

I jsut updated the tarball and removed patches now upstream.
Everything seems fine (at least on one system).

New commits:

`2a2f3c9`	`Update FLINT to version 2.4.`

sagetrac-git · 2013-12-24T00:16:19Z

Changed commit from 2a2f3c9 to 4351893

sagetrac-git · 2013-12-24T00:16:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4351893`	`Update FLINT to version 2.4.`

kiwifb · 2014-01-02T11:41:41Z

comment:4

I haven't tried inside sage yet but I have a failure with the test suite when testing the NTL interface. Does this require ntl-6?

jpflori · 2014-01-02T11:57:07Z

comment:5

I would not say so.
Maybe we just forgot to test the ntl interface when releasing FLINT 2.4, at least I did not.

kiwifb · 2014-01-02T12:15:17Z

comment:6

It's very bizarre in that it doesn't compile:

mkdir -p build/interfaces/test
if [ "1" -eq "1" ]; then \
	make build/interfaces/test/t-NTL-interface; \
	build/interfaces/test/t-NTL-interface; \
fi
make[1]: Entering directory `/scratch/portage/sci-mathematics/flint-2.4/work/flint-2.4'
x86_64-pc-linux-gnu-g++ -O1 -march=native -pipe -ggdb -DFLINT_CPIMPORT=\"/usr/share/flint/CPimport.txt\" -I/scratch/portage/sci-mathematics/flint-2.4/work/flint-2.4 -I/usr/include -I/usr/include -I/usr/include interfaces/test/t-NTL-interface.cpp build/interfaces/NTL-interface.lo -o build/interfaces/test/t-NTL-interface -L/scratch/portage/sci-mathematics/flint-2.4/work/flint-2.4 -L/usr/lib -L/usr/lib -L/usr/lib -lflint -lpthread -lmpfr -lgmp -lm -lntl ;
interfaces/test/t-NTL-interface.cpp: In function 'int test_ZZ_pE_to_fq()':
interfaces/test/t-NTL-interface.cpp:276:49: error: cannot convert 'fmpz* {aka long int*}' to 'fmpz_mod_poly_struct*' for argument '2' to 'void fq_ctx_init_modulus(fq_ctx_struct*, fmpz_mod_poly_struct*, const char*)'
interfaces/test/t-NTL-interface.cpp: In function 'int test_ZZ_pEX_to_fq_poly()':
interfaces/test/t-NTL-interface.cpp:348:49: error: cannot convert 'fmpz* {aka long int*}' to 'fmpz_mod_poly_struct*' for argument '2' to 'void fq_ctx_init_modulus(fq_ctx_struct*, fmpz_mod_poly_struct*, const char*)'
interfaces/test/t-NTL-interface.cpp: In function 'int test_zz_pE_to_fq()':
interfaces/test/t-NTL-interface.cpp:420:49: error: cannot convert 'fmpz* {aka long int*}' to 'fmpz_mod_poly_struct*' for argument '2' to 'void fq_ctx_init_modulus(fq_ctx_struct*, fmpz_mod_poly_struct*, const char*)'
interfaces/test/t-NTL-interface.cpp: In function 'int test_zz_pEX_to_fq_poly()':
interfaces/test/t-NTL-interface.cpp:490:49: error: cannot convert 'fmpz* {aka long int*}' to 'fmpz_mod_poly_struct*' for argument '2' to 'void fq_ctx_init_modulus(fq_ctx_struct*, fmpz_mod_poly_struct*, const char*)'
make[1]: *** [build/interfaces/test/t-NTL-interface] Error 1

flint 2.3 doesn't have this problem at all.

jpflori · 2014-01-02T13:06:00Z

comment:7

Yup, it's failing in newly introduced tests.
Easy enough to fix, I'll post a patch quickly.
Note that the lib should be fine.

sagetrac-git · 2014-01-02T13:45:16Z

Changed commit from 4351893 to 7b825e7

sagetrac-git · 2014-01-02T13:45:16Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7b825e7`	`Fix NTL interface tests. Reported by Francois Bissey.`

jpflori · 2014-01-02T13:46:01Z

comment:9

Should be ok now.

kiwifb · 2014-01-02T19:09:18Z

comment:10

I cannot find a patch in that commit. Also since it is really an upstream issue, has it been reported and is there a ticket or commit to reference?

jpflori · 2014-01-02T19:17:56Z

comment:11

Oops, I forgot to "git add" the patch.
And yes it will be included into 2.4.1 which should be out shortly, in fct waiting for the last report from Sage.
See flintlib/flint#40.

sagetrac-git · 2014-01-02T19:19:56Z

Changed commit from 7b825e7 to d9321c9

sagetrac-git · 2014-01-02T19:19:56Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d9321c9`	`Actually add NTL patch.`

kiwifb · 2014-01-02T19:25:08Z

comment:13

Thanks will test it once I have a few minutes.

kiwifb · 2014-01-02T22:49:41Z

comment:14

As noted on github it solved my problems. I am ok with the state of the spkg. Are we waiting for 2.4.1 or should we just go ahead with this?

sagetrac-git · 2014-01-03T12:28:42Z

Changed commit from d9321c9 to 4d35dc3

sagetrac-git · 2014-01-03T12:28:42Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4d35dc3`	`Update FLINT to version 2.4.1.`

jpflori · 2014-01-03T12:34:00Z

Reviewer: François Bissey

jpflori · 2014-01-03T12:34:00Z

Author: Jean-Pierre Flori

jpflori · 2014-01-31T15:03:39Z

comment:24

Anybody cares?
The change here is more than trivial...

defeo · 2014-01-31T17:28:43Z

Changed reviewer from François Bissey to François Bissey, Luca De Feo

defeo · 2014-01-31T17:28:43Z

comment:25

Oups, forgot about this. For such a small change, you could have left it as positive review.

kiwifb · 2014-01-31T19:53:08Z

comment:26

Really sorry too. I escaped my radar completely.

vbraun · 2014-02-02T11:36:39Z

comment:27

Does not compile on Sparc Solaris (mark on skynet):
http://build.sagemath.org/sage/builders/%20%20slow%20Skynet%20mark%20%28SunOS%205.10-32%29%20full/builds/16/steps/compile_1/logs/flint

jpflori · 2014-02-03T13:51:05Z

comment:28

Well spotted and easy enough to fix.
In Makefile.in, line 181 lacks quotes:

$(AT)if [ ! -z $(EXT_HEADERS) ]; then \

I'll report upstream and open a follow up ticket.

vbraun · 2014-02-03T13:55:51Z

comment:29

you can fix it here as we won't merge this ticket if it doesn't work...

sagetrac-git · 2014-02-03T14:10:23Z

Changed commit from 61fc38c to cdabf08

sagetrac-git · 2014-02-03T14:10:23Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`cdabf08`	`Fix test for empty string in FLINT build system.`

jpflori · 2014-02-03T14:13:00Z

comment:31

Fixed here, and patch pushed upstream.

vbraun · 2014-02-03T14:15:34Z

comment:32

looks good to me

sagetrac-git · 2014-02-03T16:46:30Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`4351893`	`Update FLINT to version 2.4.`
`7b825e7`	`Fix NTL interface tests. Reported by Francois Bissey.`
`d9321c9`	`Actually add NTL patch.`
`4d35dc3`	`Update FLINT to version 2.4.1.`
`61fc38c`	`Update flint tarball checksums for recompressed 2.4.1.`
`5271eca`	`Fix test for empty string in FLINT build system.`

sagetrac-git · 2014-02-03T16:46:30Z

Changed commit from cdabf08 to 5271eca

jpflori · 2014-02-03T16:47:02Z

comment:34

Some space/tabs copy-paste troubles...

jpflori added this to the sage-6.1 milestone Dec 23, 2013

jpflori added c: packages: standard labels Dec 23, 2013

This comment has been minimized.

Sign in to view

jpflori added the s: needs review label Dec 24, 2013

This comment has been minimized.

Sign in to view

sagetrac-git mannequin added s: needs review and removed s: positive review labels Jan 18, 2014

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014

defeo added s: positive review and removed s: needs review labels Jan 31, 2014

sagetrac-git mannequin added s: needs review and removed s: positive review labels Feb 3, 2014

vbraun added s: positive review and removed s: needs review labels Feb 3, 2014

sagetrac-git mannequin added s: needs review and removed s: positive review labels Feb 3, 2014

jpflori added s: positive review and removed s: needs review labels Feb 3, 2014

vbraun removed the s: positive review label Feb 3, 2014

vbraun closed this as completed in 97955b7 Feb 3, 2014

Update FLINT to 2.4.1 #15574

Update FLINT to 2.4.1 #15574

Comments

jpflori commented Dec 23, 2013

This comment has been minimized.

jpflori commented Dec 24, 2013

jpflori commented Dec 24, 2013

jpflori commented Dec 24, 2013

jpflori commented Dec 24, 2013

sagetrac-git mannequin commented Dec 24, 2013

sagetrac-git mannequin commented Dec 24, 2013

kiwifb commented Jan 2, 2014

jpflori commented Jan 2, 2014

kiwifb commented Jan 2, 2014

jpflori commented Jan 2, 2014

sagetrac-git mannequin commented Jan 2, 2014

sagetrac-git mannequin commented Jan 2, 2014

jpflori commented Jan 2, 2014

kiwifb commented Jan 2, 2014

jpflori commented Jan 2, 2014

sagetrac-git mannequin commented Jan 2, 2014

sagetrac-git mannequin commented Jan 2, 2014

kiwifb commented Jan 2, 2014

kiwifb commented Jan 2, 2014

sagetrac-git mannequin commented Jan 3, 2014

sagetrac-git mannequin commented Jan 3, 2014

jpflori commented Jan 3, 2014

jpflori commented Jan 3, 2014

This comment has been minimized.

jpflori commented Jan 31, 2014

defeo commented Jan 31, 2014

defeo commented Jan 31, 2014

kiwifb commented Jan 31, 2014

vbraun commented Feb 2, 2014

jpflori commented Feb 3, 2014

vbraun commented Feb 3, 2014

sagetrac-git mannequin commented Feb 3, 2014

sagetrac-git mannequin commented Feb 3, 2014

jpflori commented Feb 3, 2014

vbraun commented Feb 3, 2014

sagetrac-git mannequin commented Feb 3, 2014

sagetrac-git mannequin commented Feb 3, 2014

jpflori commented Feb 3, 2014