Sdist fails with capital-P illow

[vbraun]

The sage-sdist script tries to download pillow, but correct tarball name is Pillow.

Component: scripts

Author: Volker Braun, Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/15596 @ c7c0106

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/15596

[vbraun]

New commits:

20c0c35	correct the tarball name in sage -sdist
321a9ad	Merge remote-tracking branch 'trac/u/ohanar/pillow' into t/15596/sdist_fails_with_capital_p_illow
f005905	pillow: depends on setuptools
adc90ce	Pillow -> pillow
8987381	remove PIL (it has been replaced by Pillow)
2c055bd	Pillow: fix patch to work against 2.2.2
6690d97	doc: remove now unused environment variables
3778f42	Pillow: re-resolve #9864
6df0adb	replace PIL with Pillow

[vbraun]

Commit: 20c0c35

[vbraun]

Branch: u/vbraun/sdist_fails_with_capital_p_illow

[vbraun]

Author: Volker Braun

[vbraun]

comment:4

Only the topmost commit matters, the rest is part of #15539 and already merged (but not released since this blocks release)

[nathanncohen]

comment:7

HMmmm... I don't get what all this does (and the last commit of #15539 is f005905, which means that this ticket contains 6 commits), but it looks like they have all been written by Andrew. Soooo if you can review them by yourself it seems ^^;

Nathann

[vbraun]

comment:8

This ticket contains (in reverse order):

• the 7 commits from use Pillow instead of PIL #15539, ending with f005905
• a merge commit so I can actually trigger the problem in this branch
• the fix for the bug in the topmost commit.

[jdemeyer]

comment:9

Would it not be sufficient to revert adc90ce?

[vbraun]

comment:10

Well in #15539 we decided to (at least for now) stick with the current naming convention where the subdirectories of build/pkgs are all lower-case.

But regardless of that, we should use the tarball name from the checksums.ini file and not blindly try combinations of basename + extension. So even if we, in the future, decide to rename the directories under build/pkgs we should still merge this ticket.

[jdemeyer]

Changed branch from u/vbraun/sdist_fails_with_capital_p_illow to u/jdemeyer/ticket/15596

[jdemeyer]

Changed author from Volker Braun to Volker Braun, Jeroen Demeyer

[jdemeyer]

Changed commit from 20c0c35 to c7c0106

[jdemeyer]

comment:12

I think this is a much better solution.

---

New commits:

c7c0106

sage-sdist: copy upstream tarballs using sage-spkg

[sagetrac-mraum]

comment:14

I didn't see anything bad about Volker's solution. But I have to have a look at Jereon's changes.

Btw: why didn't the dev-script notice that Jereon changed the commit field just before I set the ticket to positive review?

[jdemeyer]

comment:15

Replying to @sagetrac-mraum:

I didn't see anything bad about Volker's solution.

It's reinventing part of the sage-spkg wheel, my solution instead directly uses sage-spkg to copy the files.

[sagetrac-mraum]

comment:16

That absolutely makes sense. Unfortunately, I won't have time to look at this until the second week of January. So if Volker has a look at Jereon's changes, he can consider his part of the patch as positively reviewed. That's all I can do for the moment.

[ohanar]

comment:17

Reviewed as part of #15580.

[jdemeyer]

comment:18

Given that it is reviewed and should be merged and the tickets even have different authors, I don't think sage-duplicate/invalid/wontfix is right.

[jdemeyer]

Reviewer: R. Andrew Ohana