Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put ATLAS archdef tarballs into patches/ARCHS and resync ATLAS-lib dir #15615

Closed
jpflori opened this issue Jan 1, 2014 · 30 comments
Closed

Put ATLAS archdef tarballs into patches/ARCHS and resync ATLAS-lib dir #15615

jpflori opened this issue Jan 1, 2014 · 30 comments

Comments

@jpflori
Copy link

jpflori commented Jan 1, 2014

Not sure why but it seems the tarballs we shipped did not make the git transition.
The ATLAS-lib dir is also outdated.
Please use the tarball at:

CC: @vbraun @dimpase

Component: packages: standard

Keywords: atlas spkg archdef cygwin

Author: Jean-Pierre Flori

Branch/Commit: u/jpflori/ticket/15615 @ d8da989

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/15615

@jpflori jpflori added this to the sage-6.1 milestone Jan 1, 2014
@jpflori
Copy link
Author

jpflori commented Jan 1, 2014

comment:1

Ive take the opportunity to add an ARM archdef tarball as provided at http://math-atlas.sourceforge.net/errata.html#armhardfp


New commits:

0553986Reintroduce ATLAS archdefs tarballs.

@jpflori

This comment has been minimized.

@jpflori
Copy link
Author

jpflori commented Jan 1, 2014

Commit: 0553986

@jpflori
Copy link
Author

jpflori commented Jan 1, 2014

Branch: u/jpflori/ticket/15615

@jpflori
Copy link
Author

jpflori commented Jan 1, 2014

Author: Jean-Pierre Flori

@jpflori

This comment has been minimized.

@jpflori
Copy link
Author

jpflori commented Jan 2, 2014

Changed keywords from atlas spkg archdef to atlas spkg archdef cygwin

@jpflori
Copy link
Author

jpflori commented Jan 2, 2014

comment:2

The ATLAS-lib issue is surely my bad as it is already wrong in the sage 5.13 tarball...
This make ATLAS not so useful on Cygwin, whence the severity change.

@jpflori jpflori changed the title Put ATLAS archdef tarballs into patches/ARCHS Put ATLAS archdef tarballs into patches/ARCHS and resync ATLAS-lib dir Jan 2, 2014
@vbraun
Copy link
Member

vbraun commented Jan 3, 2014

comment:3

Since we have to make our own ATLAS tarball anyways to embed lapack, I would be in favor of putting the archdef tarballs in there as well. Even though they are small, they are still binary stuff that we should keep out of the repo if possible.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

1154b0dUpdate ATLAS checksum.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2014

Changed commit from 0553986 to 1154b0d

@jpflori
Copy link
Author

jpflori commented Jan 3, 2014

comment:5

Replying to @vbraun:

Since we have to make our own ATLAS tarball anyways to embed lapack, I would be in favor of putting the archdef tarballs in there as well. Even though they are small, they are still binary stuff that we should keep out of the repo if possible.

Yes, we also have to generate the autotools project an d put it in.
I'm not so found of not tracking and putting the archdefs tarballs into the ATLAS tarball as there is no easy way to generate them as for the autotools project, or getting them somewhere upstream as for the lapack tarball.

@vbraun
Copy link
Member

vbraun commented Jan 4, 2014

comment:6

Putting them into our git repo doesn't make it easier to obtain the archdefs either, it jut puts binary crap into our repo. If anything, it makes it worse for non-Sage users to get the archdefs.

@jpflori
Copy link
Author

jpflori commented Jan 4, 2014

comment:7

Ok, so let's just put them somewhere on sagemath...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2014

Changed commit from 1154b0d to 46eae63

@jpflori
Copy link
Author

jpflori commented Jan 4, 2014

comment:9

Ok, now the archef tarballs are within the "upstream" tarball.
I've taken the opportunity to add a Solaris archdef tarball.
I've slightly reworked the atlas related scripts.
Please review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2014

Changed commit from 46eae63 to e56945e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

e56945eReintroduce ATLAS archdef tarballs.

@jpflori
Copy link
Author

jpflori commented Jan 4, 2014

comment:11

I've put the current archdefs at http://boxen.math.washington.edu/home/jpflori/archdefs/

@jpflori
Copy link
Author

jpflori commented Jan 14, 2014

comment:12

This fails to build on Cygwin64 when SAGE_FAT_BINARY is set, and is easy to fix: just don't force isa extensions as the win64 abi is not the same as the amd64 one and asm code cannot be assembled...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

3772086Disable ATLAS ISA extensions on Cygwin64.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2014

Changed commit from e56945e to 3772086

@vbraun
Copy link
Member

vbraun commented Jan 20, 2014

comment:14

Changing the tarball without the version (excluding the patchlevel) is not supported ATM, I think. We cache files in the upstream/ dir as package-versionwithoutpatchlevel.tar.gz, so this ticket would break builds for everybody who has the old tarball cached.

Either combine with an upstream version bump or wait until the build system can handle this case.

Apart from that, positive review ;-)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2014

Changed commit from 3772086 to f4f17d6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

f4f17d6Change package version to properly take tarball changes into account.

@jpflori

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

d8da989Merge remote-tracking branch 'trac/develop' into ticket/15615

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2014

Changed commit from f4f17d6 to d8da989

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@vbraun
Copy link
Member

vbraun commented Feb 1, 2014

Reviewer: Volker Braun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants