Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some sig_on() in Singular library #15717

Closed
jdemeyer opened this issue Jan 23, 2014 · 8 comments
Closed

Add some sig_on() in Singular library #15717

jdemeyer opened this issue Jan 23, 2014 · 8 comments

Comments

@jdemeyer
Copy link

This hangs (see #15710) and cannot be interrupted:

sage: F.<a>=CyclotomicField(49); G = F['z,w'].fraction_field(); 1/G(a^28 + a^23 - 1)

The attached branch fixes the "cannot be interrupted" part of the bug.

Depends on #14333

CC: @ppurka

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/15717 @ 13573a9

Reviewer: Punarbasu Purkayastha

Issue created by migration from https://trac.sagemath.org/ticket/15717

@jdemeyer jdemeyer added this to the sage-6.1 milestone Jan 23, 2014
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/15717

@jdemeyer
Copy link
Author

Commit: 13573a9

@jdemeyer
Copy link
Author

New commits:

1753f06Update Singular to version 3-1-6.
536a31fUpdate Singular function interface to API changes in Singular 3.1.6.
dd46991Remove description of deleted patches.
0a702e9Merge commit 'dd469911d19ed7080fec' into ticket/15710
13573a9Add some sig_on() blocks to Singular interface

@jdemeyer
Copy link
Author

Dependencies: #14333

@ppurka
Copy link
Member

ppurka commented Jan 23, 2014

comment:4

Thanks, I just tested it and this works. But, we don't need #14333. I just cherry-picked the last commit on to develop and the interrupt worked very well. :)

@jdemeyer
Copy link
Author

comment:5

Sure, but I started #15710 by checking whether #14333 would fix it and any fix for #15710 would probably need to be based on #14333. And I just copied that commit here. Given that #14333 has positive review, it's not a problem, right?

@ppurka
Copy link
Member

ppurka commented Jan 23, 2014

Reviewer: Punarbasu Purkayastha

@ppurka
Copy link
Member

ppurka commented Jan 23, 2014

comment:6

Yeah. I guess it shouldn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants