Graphics3d saves every png image twice

[nilesjohnson]

In Graphics3d.save sage creates a png file and then uses PIL to convert it to whatever format was requested. But the check for whether to save another format is broken and so sage always creates a second file, even if it's just converting from png to png.

The reason for this is a broken check for the file extension:

if ext != 'png' should instead be if ext != '.png' since ext begins with a dot!

CC: @nilesjohnson

Component: graphics

Author: Philip Robinson

Branch/Commit: u/niles/ticket/15728 @ d6024fe

Reviewer: Niles Johnson

Issue created by migration from https://trac.sagemath.org/ticket/15728

[sagetrac-probinso]

comment:2

(new to system, so please forgive)

on line 1290 :

if ext == 'png'

on line 1298 :

if ext != 'png'

so both instances of strcmp parameters are ill formed. I would like to change both of these in my commit.

[nilesjohnson]

comment:4

Replying to @sagetrac-probinso:

so both instances of strcmp parameters are ill formed. I would like to change both of these in my commit.

Right -- both should be changed :) When you upload the new commit, I'll be happy to review it.

[sagetrac-probinso]

Branch: u/probinso/ticket/15728

[nilesjohnson]

Commit: d6024fe

[nilesjohnson]

Changed branch from u/probinso/ticket/15728 to u/niles/ticket/15728

[nilesjohnson]

comment:7

Sorry I dropped this for a while -- rebased to latest development branch (6.2.beta0) and looking at it now.

---

New commits:

4b87c01	Fixed file extension checking saving for plot3d, to insure excess files aren't created
d6024fe	Trac #15728: rebase to 6.2.beta0

[nilesjohnson]

Author: Philip Robinson

[nilesjohnson]

Reviewer: Niles Johnson

[nilesjohnson]

comment:8

I'm happy with the changes and all tests pass; positive review!

[sagetrac-probinso]

comment:10

Thank you, for reviewing now that I have completed the process once I feel better about moving forward. I will remember to flag later bugs as 'needs_review' next time.

[nilesjohnson]

comment:11

No worries -- good job :) Also remember to include your full name in the Authors section of the ticket properties.