Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small problems with CHomP, followup to #15161 #15730

Closed
jhpalmieri opened this issue Jan 24, 2014 · 2 comments
Closed

small problems with CHomP, followup to #15161 #15730

jhpalmieri opened this issue Jan 24, 2014 · 2 comments

Comments

@jhpalmieri
Copy link
Member

This is a followup to #15161, fixing some problems which arose from the changes there. In particular, if CHomP was installed, then the changes at #15161 led to some doctest failures. These have mostly been corrected, except for failures as in #12607 and also that CHomP seems to be broken on my machine, so it is not computing homology groups correctly. I think we should put off actually fixing CHomP to #15202.

Component: algebraic topology

Author: John Palmieri

Branch/Commit: u/jhpalmieri/chain @ b02b283

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/15730

@jhpalmieri jhpalmieri added this to the sage-6.1 milestone Jan 24, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@tscrim
Copy link
Collaborator

tscrim commented Feb 2, 2014

comment:3

LGTM. Just to note, I'm getting two errors, which weren't there before I installed the CHomP spkg, but the first is noted in #12607:

sage -t chain_complex.py
**********************************************************************
File "chain_complex.py", line 1135, in sage.homology.chain_complex.ChainComplex_class.homology
Failed example:
    D.homology()
Expected:
    {0: 0, 1: 0, 4: 0, 5: 0}
Got:
    {}
**********************************************************************
File "chain_complex.py", line 1397, in sage.homology.chain_complex.ChainComplex_class.torsion_list
Failed example:
    C.torsion_list(5)
Expected:
    [(2, [1]), (3, [3])]
Got:
    [(2, []), (3, [])]
**********************************************************************

@tscrim
Copy link
Collaborator

tscrim commented Feb 2, 2014

Reviewer: Travis Scrimshaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants