Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWrank doctest broken on Solaris #15798

Closed
vbraun opened this issue Feb 8, 2014 · 9 comments
Closed

MWrank doctest broken on Solaris #15798

vbraun opened this issue Feb 8, 2014 · 9 comments

Comments

@vbraun
Copy link
Member

vbraun commented Feb 8, 2014

This was most likely caused by #10108:

http://build.sagemath.org/sage/builders/%20%20slow%20Skynet%20mark%20%28SunOS%205.10-32%29%20incremental/builds/11/steps/shell_5/logs/stdio

sage -t --long src/sage/interfaces/mwrank.py
**********************************************************************
File "src/sage/interfaces/mwrank.py", line 180, in sage.interfaces.mwrank.Mwrank_class.__init__
Failed example:
    M('0 -1 1 0 0')
Expected:
    'Curve [0,-1,1,0,0] :\tRank = 0\n\n\nRegulator = 1\n'
Got:
    'Curve [0,-1,1,0,0] :    Rank = 0\n\n\nRegulator = 1\n'
**********************************************************************
File "src/sage/interfaces/mwrank.py", line 233, in sage.interfaces.mwrank.Mwrank_class.__call__
Failed example:
    mwrank('0 -1 1 0 0')
Expected:
    'Curve [0,-1,1,0,0] :\tBasic pair: I=16, J=-304\n...'
Got:
    'Curve [0,-1,1,0,0] :    Basic pair: I=16, J=-304\ndisc=-76032\n2-adic index bound = 2\nBy Lemma 5.1(a), 2-adic index = 1\n2-adic index = 1\nOne (I,J) pair\nLooking for quartics with I = 16, J = -304\nLooking for Type 3 quartics:\nTrying positive a from 1 up to 1 (square a first...)\n(1,0,-4,4,0)    --trivial\n(1,0,2,4,1)     --trivial\nTrying positive a from 1 up to 1 (...then non-square a)\nFinished looking for Type 3 quartics.\nMordell rank contribution from B=im(eps) = 0\nSelmer  rank contribution from B=im(eps) = 0\nSha     rank contribution from B=im(eps) = 0\nMordell rank contribution from A=ker(eps) = 0\nSelmer  rank contribution from A=ker(eps) = 0\nSha     rank contribution from A=ker(eps) = 0\n\nUsed full 2-descent via multiplication-by-2 map\nRank = 0\nRank of S^2(E)  = 0\n\nProcessing points found during 2-descent...done:\n  now regulator = 1\n\n\nRegulator = 1\n\nThe rank and full Mordell-Weil basis have been determined unconditionally.\n (0.030118 seconds)'
**********************************************************************

CC: @JohnCremona @categorie @mwhansen

Component: elliptic curves

Keywords: mwrank

Author: John Cremona

Branch/Commit: u/cremona/ticket/15798 @ ca47580

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/15798

@vbraun vbraun added this to the sage-6.2 milestone Feb 8, 2014
@JohnCremona
Copy link
Member

comment:1

OK, but please do not revert #10108 since there was a real problem fixed there. This is just a question of putting the right expected output into a doctest to allow for whitespace differences. The output really does contain a tab character after the colon.

I hope someone knows how to fix this, other than removing tab chars from all eclib output (I count 321 lines in eclib's source code) which would be very tedious.

@vbraun
Copy link
Member Author

vbraun commented Feb 8, 2014

comment:2

The terminal decides to replace the tab character with spaces, not eclib. Just change the doctest to an ellipsis instead of testing for the presence of a tab character.

@JohnCremona
Copy link
Member

comment:3

I thought that everything after the ellipsis was ignored? Ignoring everything after the first tab would mean that the correctness of the output was not tested.

@vbraun
Copy link
Member Author

vbraun commented Feb 8, 2014

comment:4

no, you can have multiple ellipses, every one just matches some substring. See http://docs.python.org/2/library/doctest.html#directives

@JohnCremona
Copy link
Member

Author: John Cremona

@JohnCremona
Copy link
Member

Branch: u/cremona/ticket/15798

@JohnCremona
Copy link
Member

New commits:

ca47580Trac 15798: fix mwrank doctest for Solaris

@JohnCremona
Copy link
Member

Commit: ca47580

@vbraun
Copy link
Member Author

vbraun commented Feb 11, 2014

Reviewer: Volker Braun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants