-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWrank doctest broken on Solaris #15798
Comments
comment:1
OK, but please do not revert #10108 since there was a real problem fixed there. This is just a question of putting the right expected output into a doctest to allow for whitespace differences. The output really does contain a tab character after the colon. I hope someone knows how to fix this, other than removing tab chars from all eclib output (I count 321 lines in eclib's source code) which would be very tedious. |
comment:2
The terminal decides to replace the tab character with spaces, not eclib. Just change the doctest to an ellipsis instead of testing for the presence of a tab character. |
comment:3
I thought that everything after the ellipsis was ignored? Ignoring everything after the first tab would mean that the correctness of the output was not tested. |
comment:4
no, you can have multiple ellipses, every one just matches some substring. See http://docs.python.org/2/library/doctest.html#directives |
Author: John Cremona |
Branch: u/cremona/ticket/15798 |
New commits:
|
Commit: |
Reviewer: Volker Braun |
This was most likely caused by #10108:
http://build.sagemath.org/sage/builders/%20%20slow%20Skynet%20mark%20%28SunOS%205.10-32%29%20incremental/builds/11/steps/shell_5/logs/stdio
CC: @JohnCremona @categorie @mwhansen
Component: elliptic curves
Keywords: mwrank
Author: John Cremona
Branch/Commit: u/cremona/ticket/15798 @
ca47580
Reviewer: Volker Braun
Issue created by migration from https://trac.sagemath.org/ticket/15798
The text was updated successfully, but these errors were encountered: