Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Residues in SymbolicRing #15840

Closed
dkrenn opened this issue Feb 20, 2014 · 20 comments
Closed

Residues in SymbolicRing #15840

dkrenn opened this issue Feb 20, 2014 · 20 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 20, 2014

Calculate the residue of a symbolic expression.

Component: symbolics

Author: Daniel Krenn

Branch/Commit: 511b9ff

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/15840

@dkrenn dkrenn added this to the sage-6.2 milestone Feb 20, 2014
@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2014

Branch: u/dkrenn/ticket/15840

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2014

New commits:

0467df4First version of aau_howto
8931dbdWorkflow begonnen
e0d1169function 'residue' added

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2014

Commit: e0d1169

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2014

Author: Daniel Krenn

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2014

comment:5

Having some git troubles....solving them tomorrow... ;)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 21, 2014

Changed commit from e0d1169 to ddca280

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 21, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddca280function 'residue' added

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 21, 2014

comment:7

Now the correct things are pushed :)

@mezzarobba
Copy link
Member

comment:8

Hi Daniel,

Thanks for your patch!

Your code didn't work on expressions such as 1/s² (with that particular variable name). I think I fixed it.

I am still not too happy about the following:

sage: var('s')
sage: (x^s).residue(x,0)
0

but it's not clear to me what the code should do in such cases.

Also, I wonder if we shouldn't prefer a syntax such as expr.residue(x==a) for consistency with series().


New commits:

9997eaaVarious improvements to expr.residue()

@mezzarobba
Copy link
Member

Changed branch from u/dkrenn/ticket/15840 to u/mmezzarobba/15840-residue

@mezzarobba
Copy link
Member

Changed commit from ddca280 to 9997eaa

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 22, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ae62ecaVarious improvements to expr.residue()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 22, 2014

Changed commit from 9997eaa to ae62eca

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 24, 2014

Changed branch from u/mmezzarobba/15840-residue to u/dkrenn/ticket/15840

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 24, 2014

Changed commit from ae62eca to 511b9ff

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 24, 2014

comment:11

Replying to @mezzarobba:

Also, I wonder if we shouldn't prefer a syntax such as expr.residue(x==a) for consistency with series().

Yes, good idea. I changed that.


New commits:

511b9ffchanged to support x==a syntax for consistency with .series()

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 24, 2014

comment:12

Replying to @mezzarobba:

I am still not too happy about the following:

sage: var('s')
sage: (x^s).residue(x,0)
0

but it's not clear to me what the code should do in such cases.

It is also not clear to me, but this problem has to be solved in {.series()}}}. This is now #15854.

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 24, 2014

comment:13

Replying to @mezzarobba:

Your code didn't work on expressions such as 1/s² (with that particular variable name). I think I fixed it.

Thanks. I reviewed your changes; looks good.

@vbraun
Copy link
Member

vbraun commented Mar 1, 2014

Changed branch from u/dkrenn/ticket/15840 to 511b9ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants