Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import statements with both absolute and (implicit) relative imports #15952

Closed
wluebbe mannequin opened this issue Mar 16, 2014 · 6 comments
Closed

import statements with both absolute and (implicit) relative imports #15952

wluebbe mannequin opened this issue Mar 16, 2014 · 6 comments
Labels
c: python3 p: minor / 4 t: bug
Milestone
sage-6.2

Comments

@wluebbe
Copy link
Mannequin

wluebbe mannequin commented Mar 16, 2014

There are 3 modules in sage/misc mixing both absolute and local imports in a single import statement.

This is a problem with Python 3.

Also, mixing standard library imports with application specific imports is not PEP8 compliant.

Component: misc

Keywords: import

Author: Wilfried Luebbe

Branch/Commit: bf189a1

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/15952
@wluebbe wluebbe mannequin added this to the sage-6.2 milestone Mar 16, 2014
@wluebbe wluebbe mannequin added p: minor / 4 labels Mar 16, 2014
@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 16, 2014

Commit: bf189a1

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 16, 2014

Author: Wilfried Luebbe

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 16, 2014

Branch: u/wluebbe/ticket/15952

@wluebbe wluebbe mannequin added the s: needs review label Mar 16, 2014
@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:2

looks good to me

@vbraun
Copy link
Member

vbraun commented Mar 20, 2014

Changed branch from u/wluebbe/ticket/15952 to bf189a1

@vbraun vbraun closed this as completed in cde5f2c Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: minor / 4 t: bug
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
2 participants
@vbraun @fchapoton