Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for symbolic summation algorithms #15977

Closed
kcrisman opened this issue Mar 20, 2014 · 20 comments
Closed

Fix formatting for symbolic summation algorithms #15977

kcrisman opened this issue Mar 20, 2014 · 20 comments

Comments

@kcrisman
Copy link
Member

The formatting for the algorithm options for symbolic summation, e.g.
here,
is wrong.

Component: documentation

Author: Karl-Dieter Crisman

Branch/Commit: ba7a100

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/15977

@kcrisman kcrisman added this to the sage-6.2 milestone Mar 20, 2014
@kcrisman
Copy link
Member Author

Branch: u/kcrisman/ticket/15977

@kcrisman
Copy link
Member Author

comment:2

I haven't been able to actually try this because I've destroyed my Sage install somehow... but hopefully this will be good.


New commits:

d54e8d6Fixing formatting of the algorithm options for symbolic sums

@kcrisman
Copy link
Member Author

Commit: d54e8d6

@fchapoton
Copy link
Contributor

Changed commit from d54e8d6 to 4db919e

@fchapoton
Copy link
Contributor

Changed branch from u/kcrisman/ticket/15977 to public/ticket/15977

@fchapoton
Copy link
Contributor

comment:3

This looks good to me. I have taken the opportunity to correct a few links to trac using the :trac:`1234` syntax. If you agree with my changes, you can set this to positive review.


New commits:

c805cadMerge branch 'u/kcrisman/ticket/15977' of ssh://trac.sagemath.org:22/sage into 15977
4db919etrac #15977 corrected links to trac

@kcrisman
Copy link
Member Author

comment:4

I like everything about your changes except the following. (I had actually thought about doing this but figured I'd not want to cause merge issues and also save for another ticket - but hey, here you've done it!)

-            # verify that this operation does not modify the passed dictionary (#6622)
+            Verify that this operation does not modify the passed dictionary (:trac:`6622`)::
+

This is fine, but needs to be dedented. Note how it's exactly at the same indentation level as the immediately following doctest.

@fchapoton
Copy link
Contributor

comment:5

Damn, this is going to conflict with #11840, which should probably go in first.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 21, 2014

Changed commit from 4db919e to d8e2ba1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 21, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

d8e2ba1trac #15977 correction of one indentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

b037292Merge branch 'public/ticket/15977' of ssh://trac.sagemath.org:22/sage into 15977

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2014

Changed commit from d8e2ba1 to b037292

@fchapoton
Copy link
Contributor

comment:8

ok, I have solved the conflicts with #11840, and it seems to be good to go. Please double check and put into positive review if you want.

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@lftabera
Copy link
Contributor

Reviewer: Frédéric Chapoton

@lftabera
Copy link
Contributor

Author: Karl-Dieter Crisman

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@kcrisman
Copy link
Member Author

comment:12

Not sure why this has conflicts (branch is red), but I think this should be okay now other than that.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2014

Changed commit from b037292 to ba7a100

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

ba7a100Merge branch 'public/ticket/15977' of ssh://trac.sagemath.org:22/sage into 15977

@fchapoton
Copy link
Contributor

comment:15

looks good to me. I allow myself to give a positive review..

@vbraun
Copy link
Member

vbraun commented Aug 25, 2014

Changed branch from public/ticket/15977 to ba7a100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants