New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting for symbolic summation algorithms #15977
Comments
Branch: u/kcrisman/ticket/15977 |
comment:2
I haven't been able to actually try this because I've destroyed my Sage install somehow... but hopefully this will be good. New commits:
|
Commit: |
Changed branch from u/kcrisman/ticket/15977 to public/ticket/15977 |
comment:3
This looks good to me. I have taken the opportunity to correct a few links to trac using the New commits:
|
comment:4
I like everything about your changes except the following. (I had actually thought about doing this but figured I'd not want to cause merge issues and also save for another ticket - but hey, here you've done it!)
This is fine, but needs to be dedented. Note how it's exactly at the same indentation level as the immediately following doctest. |
comment:5
Damn, this is going to conflict with #11840, which should probably go in first. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
ok, I have solved the conflicts with #11840, and it seems to be good to go. Please double check and put into positive review if you want. |
Reviewer: Frédéric Chapoton |
Author: Karl-Dieter Crisman |
comment:12
Not sure why this has conflicts (branch is red), but I think this should be okay now other than that. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
looks good to me. I allow myself to give a positive review.. |
Changed branch from public/ticket/15977 to |
The formatting for the algorithm options for symbolic summation, e.g.
here,
is wrong.
Component: documentation
Author: Karl-Dieter Crisman
Branch/Commit:
ba7a100
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/15977
The text was updated successfully, but these errors were encountered: