Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _torsion_bound() for elliptic curves over relative number fields #16011

Closed
pjbruin opened this issue Mar 25, 2014 · 10 comments
Closed

Fix _torsion_bound() for elliptic curves over relative number fields #16011

pjbruin opened this issue Mar 25, 2014 · 10 comments

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Mar 25, 2014

Computing torsion subgroups of elliptic curves over relative number fields fails:

sage: R.<x> = QQ[]
sage: F.<a> = QuadraticField(5)
sage: K.<b> = F.extension(x^2-3)
sage: E = EllipticCurve(K,[0,0,0,b,1])
sage: E.torsion_subgroup()
...
NotImplementedError: For an ideal in a relative number field you must use relative_ramification_index or absolute_ramification_index as appropriate

The solution should be to make E._torsion_bound() use absolute_ramification_index() instead of ramification_index().

CC: @JohnCremona @mmasdeu

Component: elliptic curves

Keywords: relative number field ramification

Author: Marc Masdeu

Branch/Commit: 94d6219

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/16011

@pjbruin pjbruin added this to the sage-6.2 milestone Mar 25, 2014
@mmasdeu
Copy link
Sponsor

mmasdeu commented Mar 25, 2014

New commits:

0fab927Fixed torsion_order for relative number fields.

@mmasdeu
Copy link
Sponsor

mmasdeu commented Mar 25, 2014

Commit: 0fab927

@mmasdeu
Copy link
Sponsor

mmasdeu commented Mar 25, 2014

@mmasdeu
Copy link
Sponsor

mmasdeu commented Mar 25, 2014

comment:2

Done!

@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 25, 2014

Author: Marc Masdeu

@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 25, 2014

comment:3

Looks good (and very quick)! One non-essential comment on your patch: the preferred way of referring to Trac tickets is :trac:`16011` instead of #16011.

@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 25, 2014

Reviewer: Peter Bruin

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2014

Changed commit from 0fab927 to 94d6219

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2014

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

94d6219Fixed way to refer to ticket.

@vbraun
Copy link
Member

vbraun commented Mar 31, 2014

Changed branch from u/mmasdeu/torsion_relative_number_fields to 94d6219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants