Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected components for immutable digraphs does not work #16019

Closed
tscrim opened this issue Mar 26, 2014 · 9 comments
Closed

Connected components for immutable digraphs does not work #16019

tscrim opened this issue Mar 26, 2014 · 9 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Mar 26, 2014

sage: G = DiGraph([[1,2]])
sage: G.connected_components()
[[1, 2]]
sage: G.copy(immutable=True).connected_components()
...
AttributeError: 'NoneType' object has no attribute 'out_neighbors'

CC: @nathanncohen

Component: graph theory

Author: Nathann Cohen

Branch/Commit: 7635a24

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/16019

@tscrim tscrim added this to the sage-6.2 milestone Mar 26, 2014
@tscrim tscrim self-assigned this Mar 26, 2014
@tscrim

This comment has been minimized.

@nathanncohen

This comment has been minimized.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 27, 2014

Commit: 7635a24

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 27, 2014

Branch: u/ncohen/16019

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 27, 2014

Author: Nathann Cohen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 27, 2014

comment:3

sigh

That's the best I can do, and I am not proud of it ^^;

Nathann

P.S. : You are the one at fault, actually. Who the hell computes connected components on digraphs ? It does not make any sense ! :-P


New commits:

7635a24trac #16019: Broken Connected Components for immutable digraphs

@nathanncohen nathanncohen mannequin added the s: needs review label Mar 27, 2014
@tscrim
Copy link
Collaborator Author

tscrim commented Mar 27, 2014

comment:4

LGTM. Thanks Nathann.

It came up with Dynkin diagrams (which slightly abuses DiGraph) and connected components correspond to irreducible types.

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 27, 2014

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Apr 1, 2014

Changed branch from u/ncohen/16019 to 7635a24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants