remove deprecated code in rings/

[rwst]

Component: commutative algebra

Keywords: deprecation, rings

Author: Ralf Stephan

Branch/Commit: 2ecf409

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/16021

[rwst]

Commit: 75d8e88

[rwst]

New commits:

75d8e88

remove deprecated

[rwst]

Branch: u/rws/ticket/16021

[rwst]

comment:2

Argh, some problem with the branch...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4889c2f

remove spurious cruft, presumably from preious commit, caused by eclipse

[sagetrac-git]

Changed commit from 75d8e88 to 4889c2f

[sagetrac-git]

Changed commit from 4889c2f to 2ecf409

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2ecf409

fix doctests

[rwst]

comment:6

Should be good now.

[nathanncohen]

comment:7

It is. I agree with the changes, and I will set it to positive_review as soon as I can see that the tests pass.

Nathann

[nathanncohen]

Reviewer: Nathann Cohen

[nathanncohen]

comment:8

Okay, after two days trying to get the patchbot to run on my machine to test this ticket I gave up (you can see the failed attempts by clicking on the red circle at the top of this ticket).

I tested all files on my computer, it resulted in two failures which are not related to this ticket. Thus, pass ! And sorry for the delay.

Nathann

[rwst]

comment:9

Thanks for the review. As to patchbot, I had the same problem, see
sagemath/sage-patchbot#10

[vbraun]

Changed branch from u/rws/ticket/16021 to 2ecf409