Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package patch mechanism can't patch spkg-install inside spkg #16060

Closed
rwst opened this issue Apr 5, 2014 · 2 comments
Closed

package patch mechanism can't patch spkg-install inside spkg #16060

rwst opened this issue Apr 5, 2014 · 2 comments
Labels
c: scripts r: invalid t: bug

Comments

@rwst
Copy link

rwst commented Apr 5, 2014

See the scenario in #15814 where the original tarball is an SPKG with defect spkg-install. A possible fix in sage-spkg would be to first check inside build/pkgs/packagename for the spkg-install to run.

Component: scripts

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/16060
@rwst rwst added this to the sage-6.2 milestone Apr 5, 2014
@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:1

spkg-install is a file provided by Sage. No need to add a patch, just edit the file.

Close as invalid.

@jdemeyer jdemeyer removed this from the sage-6.2 milestone Apr 12, 2014
@vbraun vbraun closed this as completed Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: scripts r: invalid t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vbraun @rwst @jdemeyer