New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject_shorthands broken since 6.2beta8 #16181
Comments
comment:2
Oh, and apparently importing any(!) sage file beforehand keeps the bug from happening. Here is an example that does not throw errors:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Just doing
(before an import) is enough to cause the error. If I had to make a WAG, I'd say it's the IPython upgrade. I've added this as a doctest, so if you're happy this (and I'm okay with fixing the symptoms), positive review. |
comment:5
Unfortunately this doctest works even without the patch :( And moving it to the very front of the file doesn't help either... |
comment:6
Oops, sorry for removing you from cc, Volker (I really should report this as a trac bug -- I started writing my post before you made yours -- but I'm too lazy). |
comment:7
Hmm...there must be something going on within the doctesting framework that prevents this from begin executed before any imports. We can leave it in there as a human warning, but honestly noone is really going to look at that test (much less run it manually)... |
comment:8
BTW: when I do
And this is just the error output. Here is the actual dictionary: https://www.dropbox.com/s/6hzuqm6jf9jo9jt/outtext.txt I can't believe this all needs to be in the globals? |
comment:9
Those deprecations are from #15882 (ex. |
comment:10
Yeah, I now see it's pretty much orthogonal to what we're doing here. Good to know we've got a |
comment:11
From
I'm wondering if we should just axe the line with the |
comment:12
OK, axing doesn't work, since this line is there to undo the (apparently Sphinx-specific) setting of |
comment:13
EDIT: ignore this post. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:15
OK, forget about the second branch; I've just hijacked the main branch with what I think is a full solution. Warning: forced push! |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Travis Scrimshaw |
Author: Darij Grinberg |
comment:17
LGTM. |
comment:18
Thank you, Travis!! blush I guess I really should start reviewing... |
comment:19
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:22
ad 1: True; that was a habit from pre-git times. Removed. ad 2: I have changed it now but I'm not 100% sure (what happens if we are doctesting a package?). I don't have time to run all the doctests now... ad 3: I can't follow this. It is import-less and it stands at the beginning of the file. At least the first of these properties is crucial! |
Changed branch from public/combinat/inject_shorthands to |
Same for Sym and QSym.
The
get_main_globals
method hasn't been changed since 2011, so I suspect something else is at fault. The attached branch gets rid of the bug, but I don't understand the code at hand and so it is not really merge-ready. Needs_review is to increase visibility.CC: @nthiery @vbraun
Component: misc
Keywords: globals, inject_shorthands, regression
Author: Darij Grinberg
Branch/Commit:
648da0d
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/16181
The text was updated successfully, but these errors were encountered: