Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Five mutually orthogonal latin squares of order 12 #16236

Closed
nathanncohen mannequin opened this issue Apr 25, 2014 · 28 comments
Closed

Five mutually orthogonal latin squares of order 12 #16236

nathanncohen mannequin opened this issue Apr 25, 2014 · 28 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 25, 2014

Wuuuhuuuuuuuu !! Another construction ! Given by Brendan McKay ;-)

Nathann

Depends on #16241

CC: @videlec @KPanComputes @brettpim

Component: combinatorics

Keywords: design, mols

Author: Nathann Cohen

Branch/Commit: 2d7da8a

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/16236

@nathanncohen nathanncohen mannequin added this to the sage-6.2 milestone Apr 25, 2014
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Apr 25, 2014

Branch: u/ncohen/16236

@nathanncohen nathanncohen mannequin added the s: needs review label Apr 25, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2014

Commit: 3442d20

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

3442d20trac #16236: Five mutually orthogonal latin squares of order 12

@nathanncohen

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ddda559trac #16277: Merged with updated #16272
7570b39trac #16277: From availability to existence and broken doctests
5e8b2aftrac #16277: removes a doctests that appears several times already
acf8988trac #16277: Merged with updated #16231
0f3a755trac #16235: A pair of orthogonal latin squares of order 10
316b379trac #16235: Merged with updated #16277
e59d6cbtrac #16241: New MOLS shared by Ian Wanless
e08b0betrac #16241: missing links and tests
fb26a1etrac #16241: Merged with updated #16235
491ce08trac #16236: Five mutually orthogonal latin squares of order 12

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2014

Changed commit from 3442d20 to 491ce08

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 4, 2014

comment:5

Updated !

@videlec
Copy link
Contributor

videlec commented May 4, 2014

comment:6

adding keywords...

@videlec
Copy link
Contributor

videlec commented May 4, 2014

Changed keywords from none to design, mols

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d34b012trac #16272: Merged with updated #16227
5cab81ctrac #16286: Allow k=None in MOLS/TD/OA
4970da4trac #16286: Merged with updated #16272
cb2e272trac #16235: Merged with updated #16286
1a13ff8trac #16241: New MOLS shared by Ian Wanless
2af2acftrac #16241: missing links and tests
7e77f90trac #16241: Broken doctests
e655b36trac #16236: Five mutually orthogonal latin squares of order 12

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2014

Changed commit from 491ce08 to e655b36

@videlec
Copy link
Contributor

videlec commented May 4, 2014

comment:8

Hi Nathann,

I guess this one needs also needs to be rebased on #16286 (that is a dependency of #16235).

Vincent

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 5, 2014

Changed dependencies from #16235 to #16241

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 5, 2014

comment:9

Nonono actually this one is above #16241

@videlec
Copy link
Contributor

videlec commented May 5, 2014

comment:10

Replying to @nathanncohen:

Nonono actually this one is above #16241

Anyway, there is some rebase to do as there are some merging conflict with #16241.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2014

Changed commit from e655b36 to b516266

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a97434ftrac #16286: more doc, more tests
aeab437trac #16235: merge the updated #16286
daa3835trac #16235: case n=1 + doc
31a53f2trac #16235: update the MOLS table
83b0d2ctrac #16241: Merged with updated #16235
c212bf9trac #16241: Broken doctests
b516266trac #16236: Merged with updated #16241

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2014

Changed commit from b516266 to f5339fa

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 5, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

f5339fatrac #16236: Broken doctests

@videlec
Copy link
Contributor

videlec commented May 6, 2014

comment:15

Hi Nathann,

Don't you have better reference rather than "given by Brendan McKay"?

I thought that we moved TD6_12 from orthogonal_arrays to database... what happend?

Vincent

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 6, 2014

comment:16

Yo !

Don't you have better reference rather than "given by Brendan McKay"?

Well.... I sent him an email, he gave me the matrices .... :-P

I thought that we moved TD6_12 from orthogonal_arrays to database... what happend?

Yeah I thought I did too... Perhaps one of the conflicts, who knows ? :-D

Anyway the good news is that we did not end up with a weird situation where it has not been moved WHILE some code is trying to load it from database.py. At least it works. Well, we will fix that in a later patch. I hope that Volker will release the next beta soon, because right now the Design code is a bit "foggy". It exists as a set of differences on several trac tickets, but I would like to have it in Sage and be sure that there are no conflicts anymore :-D

Nathann

@videlec
Copy link
Contributor

videlec commented May 6, 2014

comment:17

Replying to @nathanncohen:

Yo !

Don't you have better reference rather than "given by Brendan McKay"?

Well.... I sent him an email, he gave me the matrices .... :-P

I thought that we moved TD6_12 from orthogonal_arrays to database... what happend?

Yeah I thought I did too... Perhaps one of the conflicts, who knows ? :-D

Anyway the good news is that we did not end up with a weird situation where it has not been moved WHILE some code is trying to load it from database.py. At least it works. Well, we will fix that in a later patch. I hope that Volker will release the next beta soon, because right now the Design code is a bit "foggy". It exists as a set of differences on several trac tickets, but I would like to have it in Sage and be sure that there are no conflicts anymore :-D

Me too!!

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 6, 2014

comment:18

Thanks for the review !

Nathann

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@vbraun
Copy link
Member

vbraun commented May 6, 2014

comment:20

Reviewer name

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 7, 2014

Reviewer: Vincent Delecroix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 8, 2014

Changed commit from f5339fa to 2d7da8a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 8, 2014

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

5e8b2aftrac #16277: removes a doctests that appears several times already
acf8988trac #16277: Merged with updated #16231
485e880trac #16277: Merged with updated #16248
411a759trac #16286: Merged with updated #16277
11eff2ctrac #16235: Merged with 6.2
5a0e3fetrac #16235: Merged with #16231
c0b13c4trac #16235: Merged with updated #16286
9fb0f62trac #16241: useless if condition in MOLS constructor
67ab2d2trac #16241: Merged with updated #16235
2d7da8atrac #16236: Merged with updated #16241

@vbraun
Copy link
Member

vbraun commented May 13, 2014

Changed branch from u/ncohen/16236 to 2d7da8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants