Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "first_lexicographic" option for irreducible polynomials over finite fields of odd characteristic #16359

Closed
jpflori opened this issue May 16, 2014 · 14 comments

Comments

@jpflori
Copy link

jpflori commented May 16, 2014

This is the default behavior in Magma.

CC: @defeo @pjbruin

Component: finite rings

Keywords: finite fields magma irreducible

Author: Jean-Pierre Flori

Branch/Commit: 2f34e15

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/16359

@jpflori jpflori added this to the sage-6.3 milestone May 16, 2014
@jpflori
Copy link
Author

jpflori commented May 16, 2014

Commit: 2f5b9e4

@jpflori
Copy link
Author

jpflori commented May 16, 2014

Author: Jean-Pierre Flori

@jpflori
Copy link
Author

jpflori commented May 16, 2014

Changed keywords from none to finite fields magma irreducible

@jpflori
Copy link
Author

jpflori commented May 16, 2014

Branch: u/jpflori/ticket/16359

@jpflori
Copy link
Author

jpflori commented May 16, 2014

comment:1

Maybe the non-prime case needs some thought.


New commits:

2f5b9e4Implement "first_lexicographic" option for irreducible polys over ffs.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

44d67e1Leftover degree restriction.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2014

Changed commit from 2f5b9e4 to 44d67e1

@pjbruin
Copy link
Contributor

pjbruin commented May 26, 2014

comment:3

Looks good. One question: do you really want to say "try random polynomials in lexicographic order" in the docstring?!

@jpflori
Copy link
Author

jpflori commented May 27, 2014

comment:4

Nope.
Correcting that now.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 27, 2014

Changed commit from 44d67e1 to 2f34e15

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 27, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

2f34e15Fix typo in finite field poly code.

@jpflori
Copy link
Author

jpflori commented May 27, 2014

comment:6

Done.
Now we should make it so this is as fast as Magma's implementation.
I think refactoring the finite field poly factorization code and make it use NTL/PARI/FLINT code should be enough.

@pjbruin
Copy link
Contributor

pjbruin commented May 27, 2014

Reviewer: Peter Bruin

@vbraun
Copy link
Member

vbraun commented May 29, 2014

Changed branch from u/jpflori/ticket/16359 to 2f34e15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants