Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in src/bin/sage handle -patchbot option earlier #16390

Closed
rwst opened this issue May 23, 2014 · 9 comments
Closed

in src/bin/sage handle -patchbot option earlier #16390

rwst opened this issue May 23, 2014 · 9 comments
Labels
c: scripts p: major / 3 t: bug
Milestone
sage-6.3

Comments

@rwst
Copy link

rwst commented May 23, 2014

As explained in sagemath/sage-patchbot#35 and #16377 comment:11, patchbot when started with sage -patchbot will clobber your Sage installation because the environment is changed before patchbot is started.

vbraun: "The handling of the -patchbot switch in src/bin/sage needs to be moved above the "Source sage-env" step, so it is done before the environment is changed."

Component: scripts

Author: Ralf Stephan

Branch/Commit: c017fd5

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/16390
@rwst rwst added this to the sage-6.3 milestone May 23, 2014
@rwst

This comment has been minimized.

Sign in to view
@rwst

This comment has been minimized.

Sign in to view
@rwst

This comment has been minimized.

Sign in to view
@rwst rwst changed the title remove -patchbot option to sage in src/bin/SAGE handle -patchbot option earlier May 24, 2014
@rwst
Copy link
Author

rwst commented May 30, 2014

Branch: u/rws/in_src_bin_sage_handle__patchbot_option_earlier

@rwst
Copy link
Author

rwst commented May 30, 2014

Commit: c017fd5

@rwst
Copy link
Author

rwst commented May 30, 2014

comment:5

This appears to work and, in conjunction with a fix for the setuptools problem, allows patchbot to test unsafe tickets successfully.

New commits:

c017fd516390: move up patchbot handling

@rwst rwst changed the title in src/bin/SAGE handle -patchbot option earlier in src/bin/sage handle -patchbot option earlier May 30, 2014
@rwst
Copy link
Author

rwst commented May 30, 2014

Author: Ralf Stephan

@vbraun
Copy link
Member

vbraun commented May 30, 2014

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Jun 1, 2014

Changed branch from u/rws/in_src_bin_sage_handle__patchbot_option_earlier to c017fd5

@vbraun vbraun closed this as completed in 2440c90 Jun 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: scripts p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.3
Development

No branches or pull requests
2 participants
@vbraun @rwst