Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logic error in code of _gomory_hu_tree #16404

Closed
sagetrac-foosterhof mannequin opened this issue May 27, 2014 · 9 comments
Closed

logic error in code of _gomory_hu_tree #16404

sagetrac-foosterhof mannequin opened this issue May 27, 2014 · 9 comments
Labels
c: graph theory r: duplicate t: enhancement

Comments

@sagetrac-foosterhof
Copy link
Mannequin

sagetrac-foosterhof mannequin commented May 27, 2014

The virtual (fake) vertex g2_v is added to g1, even though I think it makes alot more sense to add it to g2.

As far as I know, it does not create bugs or incorrect results, as add_edge adds the vertex if it does not exist, but it would seem rather unfavourable to keep such an error existent.

Component: graph theory

Keywords: gomory-hu tree gomory hu

Branch/Commit: u/foosterhof/ticket/16404 @ 2175685

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/16404
@sagetrac-foosterhof sagetrac-foosterhof mannequin added this to the sage-6.3 milestone May 27, 2014
@sagetrac-foosterhof
Copy link
Mannequin Author

sagetrac-foosterhof mannequin commented May 27, 2014

Branch: u/foosterhof/ticket/16404

@sagetrac-foosterhof
Copy link
Mannequin Author

sagetrac-foosterhof mannequin commented May 27, 2014

Commit: 2175685

@sagetrac-foosterhof
Copy link
Mannequin Author

sagetrac-foosterhof mannequin commented May 27, 2014

New commits:

2175685Fixed logic error in Gomory-Hu tree algorithm

@fchapoton
Copy link
Contributor

comment:3

You should try to add a doctest that tests that this change is correct, if possible.

@sagetrac-foosterhof
Copy link
Mannequin Author

sagetrac-foosterhof mannequin commented Jun 13, 2014

comment:4

This fix is redundant as I fixed it immediately when fixing ticket #16475. Can thus be closed or removed, or anything the likes.

Florian

@sagetrac-foosterhof
Copy link
Mannequin Author

sagetrac-foosterhof mannequin commented Jun 13, 2014

Upstream: None of the above - read trac for reasoning.

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@fchapoton
Copy link
Contributor

comment:6

ok, then let us say that this is a duplicate

@fchapoton
Copy link
Contributor

Changed upstream from None of the above - read trac for reasoning. to none

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton fchapoton removed this from the sage-6.4 milestone Feb 9, 2015
@vbraun vbraun closed this as completed Feb 10, 2015
@sagetrac-foosterhof sagetrac-foosterhof mannequin mentioned this issue May 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory r: duplicate t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbraun @fchapoton