Cleanup/reorganization of FLINT imports #16428

ohanar · 2014-06-03T08:36:12Z

Rename the FLINT .pxi files to .pxd files. Create a new file src/sage/libs/flint/types.pxd with just the type declarations (similar to GMP, very useful to avoid circular imports).

Component: misc

Author: R. Andrew Ohana, Jeroen Demeyer

Branch/Commit: b69be0d

Reviewer: William Stein, Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/16428

The text was updated successfully, but these errors were encountered:

williamstein · 2014-06-03T21:30:35Z

Reviewer: William Stein

sagetrac-git · 2014-06-07T04:20:46Z

Changed commit from 8393c45 to 82a574e

sagetrac-git · 2014-06-07T04:20:46Z

Branch pushed to git repo; I updated commit sha1. New commits:

`acad84e`	`Merge remote-tracking branch 'trac/develop' into cleanup_flint_imports`
`82a574e`	`fix new case of using __mpz_struct internals`

jdemeyer · 2014-10-13T18:41:55Z

Changed author from R. Andrew Ohana to R. Andrew Ohana, Jeroen Demeyer

jdemeyer · 2014-10-13T18:42:36Z

Changed branch from u/ohanar/cleanup_flint_imports to u/jdemeyer/ticket/16428

sagetrac-git · 2014-10-13T18:50:36Z

Changed commit from 82a574e to f771a79

sagetrac-git · 2014-10-13T18:50:36Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`f771a79`	`Cleanup/reorganization of FLINT imports`

sagetrac-git · 2014-10-13T19:24:38Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`1fd2237`	`Cleanup/reorganization of FLINT imports`

sagetrac-git · 2014-10-13T19:24:38Z

Changed commit from f771a79 to 1fd2237

jpflori · 2014-10-13T19:40:28Z

comment:12

Argh, I basically have a branch doing the same thing...

sagetrac-git · 2014-10-13T19:48:41Z

Changed commit from 1fd2237 to 76ea0ae

sagetrac-git · 2014-10-13T19:48:41Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`76ea0ae`	`Cleanup/reorganization of FLINT imports`

sagetrac-git · 2014-10-13T20:27:24Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`aa472fb`	`Cleanup/reorganization of FLINT imports`

sagetrac-git · 2014-10-13T20:27:24Z

Changed commit from 76ea0ae to aa472fb

sagetrac-git · 2014-10-13T20:43:33Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`9fef984`	`Cleanup/reorganization of FLINT imports`

sagetrac-git · 2014-10-13T20:43:33Z

Changed commit from aa472fb to 9fef984

sagetrac-git · 2014-10-13T20:51:15Z

Changed commit from 9fef984 to 2a2ba6d

sagetrac-git · 2014-10-13T20:51:15Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`2a2ba6d`	`Cleanup/reorganization of FLINT imports`

sagetrac-git · 2014-10-14T13:58:44Z

Changed commit from fff00d4 to ce22602

jpflori · 2014-10-14T14:06:06Z

comment:36

I see some mpz_... functions defined in Sage files have been deleted.
I guess it's because FLINT now provides similar functionalities, or at least the functions using them in Sage have changed to use other flitn functions?

jpflori · 2014-10-14T14:07:00Z

comment:37

Oops...

jdemeyer · 2014-10-14T14:09:36Z

comment:39

Replying to @jpflori:

I see some mpz_... functions defined in Sage files have been deleted.

They were unused. Some of them are actually copied to a proper .pyx file where they belong.

jdemeyer · 2014-10-14T14:10:00Z

comment:40

Eventually the whole file gmp.pxi (and other similar ones) should be gone.

jpflori · 2014-10-14T16:43:55Z

comment:41

The array things are in the wrong places in the definition of the nmod... types in types.pxd. Apart from that it looks ok.

Could you correct that in a new commit (that is not doing a forced push).
I'm currently testing the branch in a personal branch using more stuff from flint and merging forced push can be a pain sometimes.

I'll restest everything on top of a vanilla trac/develop branch a little later.

jpflori · 2014-10-14T16:45:54Z

comment:42

In fact the array stuff was already misplaced before...

jdemeyer · 2014-10-15T06:22:30Z

comment:43

Replying to @jpflori:

I'm currently testing the branch in a personal branch using more stuff from flint and merging forced push can be a pain sometimes.

Concerning forced pushes: in my mind (this is not official policy), forced pushes are fine before setting a ticket to needs_review. The alternative is not pushing until you have something ready for review, which is worse.

jdemeyer · 2014-10-15T06:26:31Z

comment:44

Replying to @jpflori:

The array things are in the wrong places in the definition of the nmod... types in types.pxd.

Please clarify (or post a reviewer patch), I have no idea what you mean.

jpflori · 2014-10-15T08:40:05Z

comment:45

There are some

ctypedef nmod_poly_struct[1] nmod_poly_t

or variations and similar
which should be

ctypedef nmod_poly_struct nmod_poly_t[1]

jpflori · 2014-10-15T12:55:32Z

Changed commit from ce22602 to b69be0d

jpflori · 2014-10-15T12:55:32Z

comment:46

I'm basically happy with Jeroen work.

Jeroen: can you double check my latest changes?
If they suit you, lgtm.

New commits:

`fc17740`	`Merge remote-tracking branch 'trac/u/jdemeyer/ticket/16428' into mpir`
`a669ec7`	`Fix test in cython.py for new FLINT layout.`
`b69be0d`	`Fix some ctypedef in FLINT pxd files.`

jpflori · 2014-10-15T12:55:32Z

Changed reviewer from William Stein to William Stein, Jean-Pierre Flori

jpflori · 2014-10-15T12:55:32Z

Changed branch from u/jdemeyer/ticket/16428 to u/jpflori/ticket/16428

jdemeyer · 2014-10-15T20:54:38Z

comment:47

Sorry, I have no idea what to do (as reviewer) with sagemath/sagetrac-mirror@fc17740

The other 2 commits obviously make sense.

jpflori · 2014-10-15T21:30:43Z

comment:48

Oops.
In fact mpir should read sage-6.4.beta6 and I just merged your branch into it...

jpflori · 2014-10-15T21:31:03Z

comment:49

So positive_review I assume.

vbraun · 2014-10-16T21:10:26Z

Changed branch from u/jpflori/ticket/16428 to b69be0d

ohanar added this to the sage-6.3 milestone Jun 3, 2014

ohanar added p: major / 3 labels Jun 3, 2014

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014

jdemeyer added s: needs work and removed s: needs review labels Oct 1, 2014

jdemeyer removed the s: needs work label Oct 13, 2014

jdemeyer closed this as completed Oct 13, 2014

jdemeyer reopened this Oct 13, 2014

This comment has been minimized.

Sign in to view

jdemeyer added the s: needs review label Oct 14, 2014

jpflori added s: positive review and removed s: needs review labels Oct 15, 2014

vbraun removed the s: positive review label Oct 16, 2014

vbraun closed this as completed in 4a2b592 Oct 16, 2014

This was referenced Jan 23, 2015

Remove gmp_globals and gmp.pxi #10103

Closed

Improve formula for Bell numbers #17157

Closed

jpflori mentioned this issue Nov 7, 2014

Refactor some generic finite field code #17165

Closed

jdemeyer mentioned this issue Oct 30, 2014

Move and fix rational reconstruction #17180

Closed

Cleanup/reorganization of FLINT imports #16428

Cleanup/reorganization of FLINT imports #16428

Comments

ohanar commented Jun 3, 2014

williamstein commented Jun 3, 2014

sagetrac-git mannequin commented Jun 7, 2014

sagetrac-git mannequin commented Jun 7, 2014

jdemeyer commented Oct 13, 2014

This comment has been minimized.

jdemeyer commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

jpflori commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 13, 2014

sagetrac-git mannequin commented Oct 14, 2014

This comment has been minimized.

This comment has been minimized.

jpflori commented Oct 14, 2014

jpflori commented Oct 14, 2014

This comment has been minimized.

jdemeyer commented Oct 14, 2014

jdemeyer commented Oct 14, 2014

jpflori commented Oct 14, 2014

jpflori commented Oct 14, 2014

jdemeyer commented Oct 15, 2014

jdemeyer commented Oct 15, 2014

jpflori commented Oct 15, 2014

jpflori commented Oct 15, 2014

jpflori commented Oct 15, 2014

jpflori commented Oct 15, 2014

jpflori commented Oct 15, 2014

jdemeyer commented Oct 15, 2014

jpflori commented Oct 15, 2014

jpflori commented Oct 15, 2014

vbraun commented Oct 16, 2014