Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use d3js package if available #16438

Closed
sagetrac-tmonteil mannequin opened this issue Jun 4, 2014 · 17 comments
Closed

Use d3js package if available #16438

sagetrac-tmonteil mannequin opened this issue Jun 4, 2014 · 17 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Jun 4, 2014

The aim of this ticket is to use the package provided by #16434 when drawing graphs, instead of fetching d3.min.js online (see #14953).

Depends on #14953
Depends on #16434

CC: @nathanncohen @sagetrac-bonfroy

Component: graph theory

Keywords: d3.js, sdl

Author: Thierry Monteil

Branch/Commit: 1ce71b1

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/16438

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-6.3 milestone Jun 4, 2014
@sagetrac-tmonteil sagetrac-tmonteil mannequin added the p: major / 3 label Jun 4, 2014
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 4, 2014

Changed keywords from none to d3.js

@sagetrac-tmonteil

This comment has been minimized.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 4, 2014

Dependencies: #14953, #16434

@sagetrac-tmonteil sagetrac-tmonteil mannequin self-assigned this Jun 4, 2014
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 4, 2014

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 4, 2014

Commit: d5c3647

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 4, 2014

New commits:

89bbeceGraph drawing in javascript using d3.js
465f9dbtrac #14953 cleanup, pep8 and details
84b44abGit directory layout
44265a5trac #14953: Merged with 6.3.beta0
9cbcc36trac #14953: Merged with 6.3.beta2
76acf85trac #14953: Moving the .html to EXT_CODE and using DOCTEST_MODE
d5c364716438 : use d3js spkg if available

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 4, 2014

comment:4

Only the last commit is to be reviewed, the other commits come from #14953 which this ticket depends on (positively reviewed but not merged yet).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2014

Changed commit from d5c3647 to 02c1091

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

02c1091Merge branch 'develop' into t/16438/use_d3js_package_if_available

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 6, 2014

Changed commit from 02c1091 to 1ce71b1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 6, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

1ce71b1#16438 move warning from code to documentation.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jun 6, 2014

comment:7

I removed the warn() command which might be annoying, instead i added warnings in the doc.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 7, 2014

Author: Thierry Monteil

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 7, 2014

Reviewer: Nathann Cohen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 7, 2014

comment:8

Excellent ! Good to go then :-)

Nathann

@vbraun
Copy link
Member

vbraun commented Jun 8, 2014

Changed branch from u/tmonteil/use_d3js_package_if_available to 1ce71b1

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Aug 27, 2019

Changed keywords from d3.js to d3.js, sdl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant