Rename xrange() to range()

[a-andre]

In python3 xrange() was renamed to range().

With this patch iterators will become lists till we switch to python 3. But this should be okay for small intervals. (That's the reason for not changing all.)

This is part of #16081.

NOTE: xrange can (and should) stay inside the code of .pyx files

CC: @jdemeyer @tscrim @a-andre @embray

Component: python3

Author: André Apitzsch, Frédéric Chapoton

Branch/Commit: dd549fa

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/16457

[a-andre]

New commits:

d3bae80

rename xrange() to range()

[a-andre]

Author: André Apitzsch

[a-andre]

Commit: d3bae80

[a-andre]

Branch: u/aapitzsch/ticket/16457

[videlec]

comment:2

I am strongly against that this ticket is being merge now. We are far from having the Python 3 switch tomorrow (is it even a blocker for sage-6.3?). It will slow down everything. xrange is faster by 40% on lists of size 100:

sage: timeit("for i in xrange(100):\n for j in xrange(100): pass")
625 loops, best of 3: 362 µs per loop
sage: timeit("for i in range(100):\n for j in range(100): pass")
625 loops, best of 3: 501 µs per loop

And there are many of them in Sage source code.

[kcrisman]

comment:3

Yeah, this does seem somewhat premature due to this. However, it's still good to have a trial version here, especially if someone decided to make a 'Sage-py3' branch for testing at some point.

[fchapoton]

comment:8

see #21375 for a step in this direction

[fchapoton]

comment:10

NOTE: xrange can (and should) stay inside the code of .pyx files

[fchapoton]

comment:11

see #21478, #21530, #21531, #21548 for some further steps

[fchapoton]

comment:12

after #21763, #21751, #21677 we will be almost done

[fchapoton]

comment:13

This is now essentially done. There remains only very few xrange in the code. Let us get rid of them here if possible.

[fchapoton]

Changed commit from d3bae80 to none

[fchapoton]

Changed branch from u/aapitzsch/ticket/16457 to none

[fchapoton]

Commit: dd549fa

[fchapoton]

comment:14

ok, here is a simple branch eliminating essentially all the remaining instances of xrange, mostly in the doc.

There will remain to handle ticket #16081.

---

New commits:

dd549fa

trac 16457 eliminate last traces of xrange

[fchapoton]

Branch: u/chapoton/16457

[fchapoton]

comment:15

at least one bot is green, please review

[fchapoton]

comment:16

ping ?

[tscrim]

Changed author from André Apitzsch to André Apitzsch, Frédéric Chapoton

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/chapoton/16457 to dd549fa