Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Lie theory documentation #16498

Closed
tscrim opened this issue Jun 18, 2014 · 16 comments
Closed

Improvements to Lie theory documentation #16498

tscrim opened this issue Jun 18, 2014 · 16 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Jun 18, 2014

Add some newer features and results into the Lie theory documentation. This also fixes typos, formatting, and flow.

CC: @sagetrac-sage-combinat @anneschilling @dwbump

Component: documentation

Keywords: sd58

Author: Travis Scrimshaw

Branch/Commit: c8f5e49

Reviewer: Dan Bump

Issue created by migration from https://trac.sagemath.org/ticket/16498

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 18, 2014

New commits:

94deba2Various changes, fixed, additions, and improvements to Lie theory.

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 18, 2014

Changed keywords from none to sd58

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 18, 2014

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 18, 2014

Commit: 94deba2

@dwbump
Copy link
Mannequin

dwbump mannequin commented Jun 19, 2014

comment:2

The changes are noncontroversial but there is a doctest failure in affine_hw_crystals.rst:

File "affine_hw_crystals.rst", line 92, in doc.en.thematic_tutorials.lie.affine_hw_crystals
Failed example:
    CM = CartanMatrix([[2, -1, -1,-1],[-1,2,-1,-1],[-1,-1,2,-1],[-1,-1,-1,2]]); M
Exception raised:
[snip]
    NameError: name 'M' is not defined

@dwbump
Copy link
Mannequin

dwbump mannequin commented Jun 19, 2014

Reviewer: bump

@dwbump dwbump mannequin added s: needs work and removed s: needs review labels Jun 19, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2014

Changed commit from 94deba2 to ef88d2a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

f994469Merge branch 'public/doc/lie_tutorial_cleanup-16498' of trac.sagemath.org:sage into pulbic/doc/lie_tutorial_cleanup-16498
ef88d2aFixed trivial typo with doctest.

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 19, 2014

Changed reviewer from bump to Dan Bump

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 19, 2014

comment:5

Whoops, fixed (and it's now based on 6.3.beta4). Is there anything you want added/expanded upon in here Dan?

@dwbump
Copy link
Mannequin

dwbump mannequin commented Jun 19, 2014

comment:6

I think there are further things that should be in the thematic tutorial but they don't have to go in this patch. For example, the methods of root lattice and weight lattice realizations for affine case.
It is best that this be a separate patch because the changes here are noncontroversial and presumably can be merged quickly.

@anneschilling
Copy link

comment:8

There is a typo in the single KR crystal section:

vertify -> verify

Also, since you mention projections, it should be mentioned which projection (onto what) gives the KR crystals.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2014

Changed commit from ef88d2a to c8f5e49

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2014

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

c8f5e49Fixed typo and added projection image for level 0 crystals.

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 20, 2014

comment:10

Fixed and done. If you're happy with the change, please set this back to positive review.

@vbraun
Copy link
Member

vbraun commented Jun 21, 2014

Changed branch from public/doc/lie_tutorial_cleanup-16498 to c8f5e49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants