ellipsis for doctest line numbers

[vbraun]

Warnings (including deprecations) should be of the form

   sage: raise_warning()
   doctest:...: Warning: this is a warning

Note the ellipsis. Putting the actual source line number in there is not cool.

Depends on #16504

CC: @nathanncohen @dimpase

Component: doctest coverage

Author: Volker Braun

Branch/Commit: 5e81606

Reviewer: Martin Albrecht, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/16626

[vbraun]

Dependencies: #16504

[vbraun]

comment:2

Depends on #16504 to avoid conflicts.

[vbraun]

Branch: u/vbraun/ellipsis_for_doctest_line_numbers

[vbraun]

New commits:

b1f43af	trac #16504: A mandatory 'nonnegative' argument for MixedIntegerLinearProgram.new_variable() until the standard changes
e9ac71d	trac #16504: Tastes and colors ................
d437be4	trac #16504: Broken doctest
ebc3316	trac #16504: additional doctest for nonnegative=False
e6ff553	Cosmetic changes
1903937	trac #16504: Updates the tutorial
27a0bce	trac #16504: Merged with beta5
45bc937	trac #16504: Broken doctest
987faab	Ellipsize the source line number in warnings

[vbraun]

Author: Volker Braun

[vbraun]

Commit: 987faab

[kcrisman]

comment:5

The dumb question which needs to be asked is whether there is any mechanism here for making sure it doesn't come back. At a minimum, is this in the developer guide? Otherwise there will be more tickets 'fixing' this.

On a different note, what was # doctest: +ELLIPSIS for? Some truly ancient way to mark that the ellipsis should behave as it does now?

[vbraun]

comment:6

I'll add a check to the doctest framework.

In plain python you need to turn on ellipsis per doctest, but we made it default.

[sagetrac-git]

Changed commit from 987faab to 7361632

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7361632

Check doctest output for source line numbers

[vbraun]

comment:8

Done, will now raise an error similar to how tabs raise an error.

[kcrisman]

comment:9

Should get an opinion from someone who understands the doctest framework better, but this answers all my questions and then some.

[malb]

Reviewer: Martin Albrecht

[malb]

comment:10

Looks okay to me (I ignored all MIP stuff when reading)

[dimpase]

comment:11

Volker, could you say what happens with mip.pyx here - it's quite a patch...

[dimpase]

Changed reviewer from Martin Albrecht to Martin Albrecht, Dima Pasechnik

[malb]

comment:13

AFAIK it's in there because o the dependency: #16504

[dimpase]

comment:14

OK, makes sense.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

e7a97ea	trac #16553: doc fix + deprecation is_block_design
3c0dd71	trac #16553v3: change .points() -> .ground_set()
52b7177	trac #16553: merge sage 6.3.beta5
0698433	trac #16553: deprecated alias .points() + fix
fb636aa	trac #16622: Hypergraph is now an incidence structure
9f70459	trac #16622: Changing the terminology
cb60470	trac #16622: Broken doc
cd7ba1a	trac #16622: More doc fixes
20b3b4a	trac #16622: HyperGraphGenerators --> HypergraphGenerators
30f094a	Merge #16622

[sagetrac-git]

Changed commit from 7361632 to 30f094a

[vbraun]

comment:16

I merged in #16622 to resolve a merge conflict

[sagetrac-git]

Changed commit from 30f094a to 5e81606

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

5e81606

Fix more source line numbers from #16622

[vbraun]

Changed branch from u/vbraun/ellipsis_for_doctest_line_numbers to 5e81606