Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncidenceStructure.degree #16701

Closed
nathanncohen mannequin opened this issue Jul 22, 2014 · 19 comments
Closed

IncidenceStructure.degree #16701

nathanncohen mannequin opened this issue Jul 22, 2014 · 19 comments
Labels
c: combinatorial designs p: major / 3 t: enhancement
Milestone
sage-6.3

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 22, 2014

That's all !

Nathann

CC: @videlec @KPanComputes @dimpase @brettpim

Component: combinatorial designs

Author: Nathann Cohen

Branch/Commit: ec241b8

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/16701
@nathanncohen nathanncohen mannequin added this to the sage-6.3 milestone Jul 22, 2014
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 22, 2014

Branch: u/ncohen/16701

@nathanncohen nathanncohen mannequin added the s: needs review label Jul 22, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

9c7d82etrac #16701: IncidenceStructure.degree

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2014

Commit: 9c7d82e

@dimpase
Copy link
Member

dimpase commented Jul 22, 2014

comment:3

please change

associating a point with its degree is returned.

to

associating the points with their degrees is returned.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2014

Changed commit from 9c7d82e to 5a11312

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

5a11312trac #16701: A fix for a blasphemy

@dimpase
Copy link
Member

dimpase commented Jul 22, 2014

comment:5

and the spacing, around =, etc, it's so, so un-PEP-8...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2014

Changed commit from 5a11312 to ec241b8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 22, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

ec241b8trac #16701: Tribute to pep8 fascism

@dimpase
Copy link
Member

dimpase commented Jul 22, 2014

comment:7

p=None -> p = None, please...

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 22, 2014

comment:8

Replying to @dimpase:

p=None -> p = None, please...

Over my dead body. Here is the outut of pep8 when I do the change you want :

incidence_structures.py:471:23: E251 unexpected spaces around keyword / parameter equals

Nathann

@dimpase
Copy link
Member

dimpase commented Jul 22, 2014

comment:9

OK...

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 22, 2014

comment:10

Thaaaaaaaaaaaanks :-P

Nathann

@vbraun
Copy link
Member

vbraun commented Jul 22, 2014

comment:11

Reviewer name

@dimpase
Copy link
Member

dimpase commented Jul 22, 2014

Reviewer: Dima Pasechnik

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 22, 2014

Changed reviewer from Dima Pasechnik to none

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 22, 2014

comment:14

Wrong ticket.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 22, 2014

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Jul 23, 2014

Changed branch from u/ncohen/16701 to ec241b8

@vbraun vbraun closed this as completed in 8018b16 Jul 23, 2014
@nathanncohen nathanncohen mannequin mentioned this issue Aug 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorial designs p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.3
Development

No branches or pull requests
2 participants
@vbraun @dimpase