Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean and speed up doctesting of bessel.py #16737

Closed
rwst opened this issue Jul 30, 2014 · 17 comments
Closed

clean and speed up doctesting of bessel.py #16737

rwst opened this issue Jul 30, 2014 · 17 comments

Comments

@rwst
Copy link

rwst commented Jul 30, 2014

70% of long doctesting concerns four complex plots in bessel.py. Setting plot_points=10 will probably not affect doctest quality but would be much faster. Even if done with image output there seems no difference in quality of the produced images.

This ticket applies all cleanup changes of #16023 and #16173 that are in bessel.py, as well as setting plot_points=10. It results in a reduction of long doctesting time by 80%.

Component: symbolics

Keywords: special, speed

Author: Ralf Stephan

Branch/Commit: 787c83f

Reviewer: Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/16737

@rwst rwst added this to the sage-6.3 milestone Jul 30, 2014
@rwst
Copy link
Author

rwst commented Jul 30, 2014

@rwst
Copy link
Author

rwst commented Jul 30, 2014

Commit: 045001c

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Jul 30, 2014

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented Jul 30, 2014

New commits:

28c188b16173: remove deprecated Bessel.call() functions
d1c868716173: save some doctests from deprecated code
9554f1f16173: remove deprecated code
88e54fdMerge branch 'develop' into t/16173/remove__bessel_functions
9b71286Merge branch 'develop' into t/16173/remove__bessel_functions
045001c16737: speed up long doctests

@fchapoton
Copy link
Contributor

comment:3

You should use :trac:`10251`

@kcrisman
Copy link
Member

kcrisman commented Aug 1, 2014

comment:4

Do you still need long time in this case? Also, perhaps a # comment about how we speed it up with fewer plot_points would help readers unfamiliar with that function.

By the way, I find that the different regions differentiate themselves better with plot_points=20...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2014

Changed commit from 045001c to d31b35f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a30d30aMerge branch 'develop' into t/16737/clean_and_speed_up_doctesting_of_bessel_py
d31b35f16737: fix and enhance docs, set plot_points to 20

@rwst
Copy link
Author

rwst commented Aug 2, 2014

comment:6

All done, and included the string "Set plot_points to a higher value to get more detail"

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2014

Changed commit from d31b35f to 787c83f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

787c83fMerge branch 'develop' into t/16737/clean_and_speed_up_doctesting_of_bessel_py

@rwst
Copy link
Author

rwst commented Aug 15, 2014

comment:9

I cannot see a commit from #16173 that is not included in my branch of this ticket, and I just pushed it, so it must be on trac too.

@kcrisman
Copy link
Member

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member

Changed merged from #16173 to none

@kcrisman
Copy link
Member

comment:10

Okay, I got beta0 working and the two changes specific to this ticket are fine and I already checked they look good before. Nice.

@vbraun
Copy link
Member

vbraun commented Aug 16, 2014

Changed branch from u/rws/clean_and_speed_up_doctesting_of_bessel_py to 787c83f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants