Add optional Arb package (arbitrary-precision floating-point ball arithmetic) #16747

sagetrac-ktkohl · 2014-07-31T15:42:30Z

Add Arb http://fredrikj.net/arb/ as an optional/experimental package.
Source code here: https://www.math.aau.at/user/cheuberg/sage/arb-2.3.0.tar.gz
(This is a renamed version of the original tarball at https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz, see the comment by jdemeyer)

CC: @sagetrac-alina @fredrik-johansson @mezzarobba

Component: packages: optional

Keywords: arb, optional package. interval field

Author: Karen Kohl, Laura Peskin, Clemens Heuberger

Branch/Commit: ec0aae9

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/16747

The text was updated successfully, but these errors were encountered:

sagetrac-ktkohl · 2014-07-31T16:00:03Z

Changed author from ktkohl to ktkohl, lpeskin

sagetrac-ktkohl · 2014-07-31T23:08:07Z

Branch: u/ktkohl/ticket/16747

sagetrac-ktkohl · 2014-07-31T23:11:21Z

Commit: a2c8861

sagetrac-ktkohl · 2014-07-31T23:11:21Z

comment:4

How do I get the arb-2.2.tar.bz2 to be part of the commit?

New commits:

`a2c8861`	`Sage install files for Arb 2.2`

cheuberg · 2014-08-08T12:59:05Z

Changed branch from u/ktkohl/ticket/16747 to u/cheuberg/ticket/16747

cheuberg · 2014-08-08T13:03:22Z

comment:6

I modified the patch:

use the .tar.gz file from github with version number instead of unversioned .zip file
use Sage's versions of flint, mpfr, gmp in building the package (if there is no version of one of those in the system paths, then the optional package won't compile).
Set package version to 2.2.0 to match the name of the top level directory of the .tar.gz file so that no renaming to src is necessary.

In that version, it compiles for me.

Are you planning to provide and include python bindings for the library?

New commits:

`a2c8861`	`Sage install files for Arb 2.2`
`40eccd8`	`Use Sage's flint, mpfr, gmp instead of possibly locally installed versions`
`c66113f`	`Use .tar.gz file from github, Version is 2.2.0, then no rename to src is necessary.`

cheuberg · 2014-08-08T13:03:22Z

Changed commit from a2c8861 to c66113f

cheuberg · 2014-09-01T16:10:54Z

comment:8

Replying to @sagetrac-ktkohl:

How do I get the arb-2.2.tar.bz2 to be part of the commit?

In the developer guide, it says "If all went fine, open a ticket, put a link to the original tarball in the ticket and upload a branch with the code under SAGE_ROOT/build/pkgs." So IMHO, there is nothing else to do.

fredrik-johansson · 2014-09-01T17:06:39Z

comment:9

I recently updated the makefile in Arb (requires a git checkout). This might solve some potential build issues with the 2.2 release.

cheuberg · 2014-09-23T06:24:23Z

comment:10

Replying to @fredrik-johansson:

I recently updated the makefile in Arb (requires a git checkout). This might solve some potential build issues with the 2.2 release.

For the sage spkg, it would probably be easier to have a release on github with that change.

@original authors: is there a reason why the status of this patch is not "needs_review"? I'd also like to renew my question on whether you plan to provide python bindings.

fredrik-johansson · 2014-09-25T12:44:37Z

comment:11

I will make a new release soon.

I've also just added methods arb_get_interval_mpfr/arb_set_interval_mpfr which should simplify conversion to/from Sage's RIF and CIF.

fredrik-johansson · 2014-09-25T17:20:18Z

comment:12

https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz is available

sagetrac-git · 2014-10-17T07:31:45Z

Changed commit from c66113f to f2c5b0b

sagetrac-git · 2014-10-17T07:31:45Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f2c5b0b`	`Trac #16747: Update arb to version 2.3.0`

cheuberg · 2014-10-17T07:36:14Z

comment:14

Updated to version 2.3.0; replaced usernames of original ticket authors by their full names as given by SPKG.txt.

cheuberg · 2014-10-17T07:36:14Z

Changed author from ktkohl, lpeskin to Karen Kohl, Laura Peskin, Clemens Heuberger

cheuberg · 2014-10-17T07:36:14Z

Changed keywords from none to arb, optional package. interval field

jdemeyer · 2014-10-17T08:28:07Z

comment:15

The tarball name is too strange: it should contain the package name (arb-2.3.0.tar.gz)

jdemeyer · 2014-10-17T08:29:11Z

comment:16

Is the -j1 needed for $MAKE install?

jdemeyer · 2014-10-17T08:31:26Z

comment:17

Try to avoid long lines like

Arb is a C library for arbitrary-precision floating-point ball arithmetic, developed by Fredrik Johansson (fredrik.johansson@gmail.com). It supports efficient high-precision computation with polynomials, power series, matrices and special functions over the real and complex numbers, with automatic, rigorous error control.

vbraun · 2014-10-17T09:06:52Z

comment:18

We most likely really need the --libdir="$SAGE_LOCAL/lib". Some systems have hacked lt to install libraries in strange locations by default.

sagetrac-git · 2014-10-19T04:38:38Z

Changed commit from f2c5b0b to 7487164

sagetrac-git · 2014-10-19T04:38:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f3f169d`	`Trac #16747: Wrap long lines`
`f3ffd68`	`Trac #16747: remove "-j1" from make install`
`7487164`	`Trac #16747: remove --libdir`

cheuberg · 2014-10-19T04:48:10Z

comment:20

Replying to @jdemeyer:

The tarball name is too strange: it should contain the package name (arb-2.3.0.tar.gz)

I cannot change the original name on github, therefore I downloaded a copy, renamed the tarball and placed it in my own webspace, see the modified description of the ticket.

cheuberg · 2014-10-19T04:52:53Z

comment:21

Replying to @jdemeyer:

Is the -j1 needed for $MAKE install?

IMHO it is not needed and removing it should not have any effects (the only dependency of make install is the library which should have been compiled in parallel before; then make install creates two directories and copies a few files into these directories, but these steps would not be run in parallel, anyway). So -j1 is removed in commit f3ffd68.

cheuberg · 2014-10-19T04:54:37Z

comment:22

Replying to @jdemeyer:

Try to avoid long lines

done in commit f3f169d.

cheuberg · 2014-10-19T05:02:24Z

comment:23

Replying to @vbraun:

We most likely really need the --libdir="$SAGE_LOCAL/lib". Some systems have hacked lt to install libraries in strange locations by default.

The .configure script of arb does not support the option --libdir. Its Makefile.in uses $(DESTDIR)$(PREFIX)/lib (and $(DESTDIR)$(PREFIX)/include) as targets when installing the library.
Therefore, commit 7487164 removes --libdir (previously commented out).

vbraun · 2014-10-19T11:05:50Z

comment:24

Argh, no autotools/libtool :-(

cheuberg · 2014-10-22T06:48:36Z

comment:25

Rather minimal python bindings are now in #17194

cheuberg · 2014-10-29T09:02:33Z

comment:27

See discussion on sage-devel concerning the section SPKG Maintainers.

sagetrac-git · 2014-10-31T18:55:15Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ec0aae9`	`Trac #16747: Remove SPKG Maintainers section`

sagetrac-git · 2014-10-31T18:55:15Z

Changed commit from 7487164 to ec0aae9

jdemeyer · 2014-11-06T12:50:51Z

Reviewer: Jeroen Demeyer

vbraun · 2014-11-15T16:22:39Z

Changed branch from u/cheuberg/ticket/16747 to ec0aae9

sagetrac-ktkohl mannequin added this to the sage-6.3 milestone Jul 31, 2014

sagetrac-ktkohl mannequin added c: packages: optional labels Jul 31, 2014

This comment has been minimized.

Sign in to view

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014

This comment has been minimized.

Sign in to view

cheuberg added the s: needs review label Oct 17, 2014

jdemeyer added s: needs work and removed s: needs review labels Oct 17, 2014

This comment has been minimized.

Sign in to view

cheuberg added s: needs review and removed s: needs work labels Oct 19, 2014

jdemeyer added s: positive review and removed s: needs review labels Nov 6, 2014

vbraun removed the s: positive review label Nov 15, 2014

vbraun closed this as completed in 1e39935 Nov 15, 2014

mezzarobba mentioned this issue Oct 30, 2015

Make arb a standard package #18546

Closed

Add optional Arb package (arbitrary-precision floating-point ball arithmetic) #16747

Add optional Arb package (arbitrary-precision floating-point ball arithmetic) #16747

Comments

sagetrac-ktkohl mannequin commented Jul 31, 2014

sagetrac-ktkohl mannequin commented Jul 31, 2014

sagetrac-ktkohl mannequin commented Jul 31, 2014

sagetrac-ktkohl mannequin commented Jul 31, 2014

sagetrac-ktkohl mannequin commented Jul 31, 2014

cheuberg commented Aug 8, 2014

cheuberg commented Aug 8, 2014

cheuberg commented Aug 8, 2014

This comment has been minimized.

cheuberg commented Sep 1, 2014

fredrik-johansson commented Sep 1, 2014

cheuberg commented Sep 23, 2014

fredrik-johansson commented Sep 25, 2014

fredrik-johansson commented Sep 25, 2014

sagetrac-git mannequin commented Oct 17, 2014

sagetrac-git mannequin commented Oct 17, 2014

cheuberg commented Oct 17, 2014

cheuberg commented Oct 17, 2014

This comment has been minimized.

cheuberg commented Oct 17, 2014

jdemeyer commented Oct 17, 2014

jdemeyer commented Oct 17, 2014

jdemeyer commented Oct 17, 2014

vbraun commented Oct 17, 2014

sagetrac-git mannequin commented Oct 19, 2014

sagetrac-git mannequin commented Oct 19, 2014

This comment has been minimized.

cheuberg commented Oct 19, 2014

cheuberg commented Oct 19, 2014

cheuberg commented Oct 19, 2014

cheuberg commented Oct 19, 2014

vbraun commented Oct 19, 2014

cheuberg commented Oct 22, 2014

cheuberg commented Oct 29, 2014

sagetrac-git mannequin commented Oct 31, 2014

sagetrac-git mannequin commented Oct 31, 2014

jdemeyer commented Nov 6, 2014

vbraun commented Nov 15, 2014