Allow gperftools.top to return a string

[sagetrac-mraum]

The text report of gperftools is printed to stdout, but in order to access it in other methods (e.g., citations), we need the it to return the report as a string. This adds an optional parameter to the method top.

CC: @vbraun

Component: misc

Author: Martin Raum

Branch/Commit: u/mraum/ticket/16778 @ 94caae0

Issue created by migration from https://trac.sagemath.org/ticket/16778

[sagetrac-mraum]

Branch: u/mraum/ticket/16778

[sagetrac-mraum]

Commit: 4fab9ea

[sagetrac-mraum]

New commits:

eb9376a	initial version
34123bf	consistenly use lower-case names for normalized (according to the first nontrivial Fourier coefficient) forms
34c3567	support to specify form spaces/rings by the parameter n instead of the parameter group, use the same name for the form space/ring classes as their representation name
ae4f782	added __init__.py
5616d62	Merge branch 'master' of git://git.sagemath.org/sage
4fab9ea	Possibility to return top as string in gperftools.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

94caae0

Possibility to return top as string in gperftools.

[sagetrac-git]

Changed commit from 4fab9ea to 94caae0

[vbraun]

comment:4

I'm against the last commit. You have a method to "Print text report" and you added an option to precisely not do that. WTF? Do you think that is a sane UI? If you want to save the output to a file there is already "save". If saving to a temporary file and loading said file is a common occurence then add an appropriately-named method, string() or stdout() or something like that.

[vbraun]

comment:5

PS: Sorry for the strong language ;-)

PPS: "ppprofiler" has at least one p too many, no?

[sagetrac-mraum]

comment:6

That's all right (I mean the language). As for the commit, I see what you mean. My focus is on citation management at #16777. So I would postpone work on profiling. Eventually an interface unifying cProfile and gperftools would be nice. But that's not for today, and requires more thorough thining.

Close as wontfix then?