Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of floordiv is incorrect for polynomials over finite fields #16781

Closed
JohnCremona opened this issue Aug 7, 2014 · 11 comments
Closed

Comments

@JohnCremona
Copy link
Member

As reported on sage-devel, the following is incorrect:

sage: F = GF(47)
sage: x = polygen(F)
sage: u = F(1)
sage: x//u
0

since x//u should give the quotient after dividing x by u.

This is fixed by #2034, so this ticket just adds a doctest.

Depends on #2034

Component: algebra

Keywords: polynomial division

Author: Jeroen Demeyer

Branch/Commit: bca94fc

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/16781

@JohnCremona JohnCremona added this to the sage-6.3 milestone Aug 7, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@jdemeyer
Copy link

Dependencies: #2034

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

Branch: u/jdemeyer/ticket/16781

@jdemeyer
Copy link

New commits:

5e8a5e3Implement `__floordiv__` in the coercion model
227e8bbAdd doctest for floor division

@jdemeyer
Copy link

Author: Jeroen Demeyer

@jdemeyer
Copy link

Commit: 227e8bb

@videlec
Copy link
Contributor

videlec commented Jan 20, 2016

comment:6

Could you be more careful with

sage: 1 // x
0

and actually test the parent of the "0" you got?

@videlec
Copy link
Contributor

videlec commented Jan 20, 2016

Reviewer: Vincent Delecroix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2016

Changed commit from 227e8bb to bca94fc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

bca94fcDoctest also the parent of floor division

@vbraun
Copy link
Member

vbraun commented Jan 23, 2016

Changed branch from u/jdemeyer/ticket/16781 to bca94fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants