Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement construction of finite state machine by copying another machine #16787

Closed
cheuberg opened this issue Aug 9, 2014 · 10 comments
Closed

Comments

@cheuberg
Copy link
Contributor

cheuberg commented Aug 9, 2014

sage: F = FiniteStateMachine()
sage: FiniteStateMachine(F)

led to a NotImplementedError.

This is now implemented.

Depends on #16786 as the documentation refers to the attributes input_alphabet, output_alphabet.

Depends on #16786

CC: @dkrenn @sagetrac-skropf

Component: finite state machines

Keywords: copy, initialization

Author: Clemens Heuberger

Branch/Commit: 90e60b5

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/16787

@cheuberg cheuberg added this to the sage-6.3 milestone Aug 9, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@dkrenn
Copy link
Contributor

dkrenn commented Nov 11, 2014

Changed branch from u/cheuberg/fsm/copy-from-other to u/dkrenn/fsm/copy-from-other

@dkrenn
Copy link
Contributor

dkrenn commented Nov 11, 2014

Changed commit from 0b55463 to 04fdac4

@dkrenn
Copy link
Contributor

dkrenn commented Nov 11, 2014

comment:4

I've moved the tests with wrong input to the test section. Apart from this, everything looks good, doctests pass and so on. Positive for me; feel free to set it to positive_review after cross-reviewing my changes.


New commits:

04fdac4moved tests to TEST-section of docstring

@dkrenn
Copy link
Contributor

dkrenn commented Nov 11, 2014

Reviewer: Daniel Krenn

@cheuberg
Copy link
Contributor Author

Changed branch from u/dkrenn/fsm/copy-from-other to u/cheuberg/fsm/copy-from-other

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2014

Changed commit from 04fdac4 to 90e60b5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

90e60b5Merge branch 'develop' into fsm/copy-from-other

@cheuberg
Copy link
Contributor Author

comment:7

Your change is fine; however, commit 04fdac4 lead to a merge conflict with #16538. I therefore merge 6.4.rc1.

Please cross-review the resolution of the merge conflict.

@cheuberg

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Nov 16, 2014

Changed branch from u/cheuberg/fsm/copy-from-other to 90e60b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants