New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement construction of finite state machine by copying another machine #16787
Comments
Changed branch from u/cheuberg/fsm/copy-from-other to u/dkrenn/fsm/copy-from-other |
comment:4
I've moved the tests with wrong input to the test section. Apart from this, everything looks good, doctests pass and so on. Positive for me; feel free to set it to positive_review after cross-reviewing my changes. New commits:
|
Reviewer: Daniel Krenn |
Changed branch from u/dkrenn/fsm/copy-from-other to u/cheuberg/fsm/copy-from-other |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Changed branch from u/cheuberg/fsm/copy-from-other to |
led to a
NotImplementedError
.This is now implemented.
Depends on #16786 as the documentation refers to the attributes
input_alphabet
,output_alphabet
.Depends on #16786
CC: @dkrenn @sagetrac-skropf
Component: finite state machines
Keywords: copy, initialization
Author: Clemens Heuberger
Branch/Commit:
90e60b5
Reviewer: Daniel Krenn
Issue created by migration from https://trac.sagemath.org/ticket/16787
The text was updated successfully, but these errors were encountered: