Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make affine and projective dehomogenize and homogenize work together #16838

Closed
bhutz opened this issue Aug 16, 2014 · 16 comments
Closed

make affine and projective dehomogenize and homogenize work together #16838

bhutz opened this issue Aug 16, 2014 · 16 comments

Comments

@bhutz
Copy link

bhutz commented Aug 16, 2014

There are a number of issues currently with the homogenization and dehomogenization functionality. Essentially, what I'd like to see is that dehomogenizing and then homogenizing returns basically the same object. Currently dehomogenization is using AffinePatch, but homogenization is creating a new projective space every time. This causes a number of funny behaviors so should instead be using projective embedding. I'd like to see tests of the following form return True:

P.<x,y,z>=ProjectiveSpace(QQ,2)
H=End(P)
f=H([x*y,y^2,z^2])
n=1
f.dehomogenize(n).homogenize(n)==f
A.<x,y>=AffineSpace(QQ,2)
H=End(A)
f=H([x*y,y^2])
n=0
f.homogenize(n).dehomogenize(n)==f

This also requires having the affine_patch and projective_embedding play nicely together. Fixing this would also allow objects homogenized or dehomogenized from the same space to then live in the same new space. The same for points and currently there is no homogenization function at all for affine points.

I've started working on this and just need to fix a couple more things.

Component: algebraic geometry

Author: Ben Hutz

Branch: 8815855

Reviewer: Joao Alberto de Faria

Issue created by migration from https://trac.sagemath.org/ticket/16838

@bhutz bhutz added this to the sage-6.4 milestone Aug 16, 2014
@bhutz bhutz self-assigned this Aug 16, 2014
@bhutz
Copy link
Author

bhutz commented Aug 16, 2014

Branch: u/bhutz/ticket/16838

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

c3d007f16838: fixes for algebraic subschemes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2014

Commit: c3d007f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2014

Changed commit from c3d007f to 30e8fde

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

30e8fde16838: fix issues with homogenize morphism

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

16efbbe16838: slight correction to homogenize

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2014

Changed commit from 30e8fde to 16efbbe

@bhutz
Copy link
Author

bhutz commented Aug 25, 2014

Author: Ben Hutz

@sagetrac-jdefaria
Copy link
Mannequin

sagetrac-jdefaria mannequin commented Sep 3, 2014

comment:6

Outside of a couple of small typos with spacing around equality signs, everything else looks good, ran the long test and confirmed that all tests passed.

@sagetrac-jdefaria
Copy link
Mannequin

sagetrac-jdefaria mannequin commented Sep 3, 2014

Reviewer: Joao de Faria

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 3, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

881585516838: fixed some typos

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 3, 2014

Changed commit from 16efbbe to 8815855

@sagetrac-jdefaria
Copy link
Mannequin

sagetrac-jdefaria mannequin commented Sep 3, 2014

comment:9

Everything looks good.

@vbraun
Copy link
Member

vbraun commented Sep 6, 2014

Changed branch from u/bhutz/ticket/16838 to 8815855

@kcrisman
Copy link
Member

Changed commit from 8815855 to none

@kcrisman
Copy link
Member

Changed reviewer from Joao de Faria to Joao Alberto de Faria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants