New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make affine and projective dehomogenize and homogenize work together #16838
Comments
Branch: u/bhutz/ticket/16838 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Ben Hutz |
comment:6
Outside of a couple of small typos with spacing around equality signs, everything else looks good, ran the long test and confirmed that all tests passed. |
Reviewer: Joao de Faria |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Everything looks good. |
Changed branch from u/bhutz/ticket/16838 to |
Changed commit from |
Changed reviewer from Joao de Faria to Joao Alberto de Faria |
There are a number of issues currently with the
homogenization
anddehomogenization
functionality. Essentially, what I'd like to see is that dehomogenizing and then homogenizing returns basically the same object. Currently dehomogenization is usingAffinePatch
, but homogenization is creating a new projective space every time. This causes a number of funny behaviors so should instead be using projective embedding. I'd like to see tests of the following form returnTrue
:This also requires having the
affine_patch
andprojective_embedding
play nicely together. Fixing this would also allow objects homogenized or dehomogenized from the same space to then live in the same new space. The same for points and currently there is no homogenization function at all for affine points.I've started working on this and just need to fix a couple more things.
Component: algebraic geometry
Author: Ben Hutz
Branch:
8815855
Reviewer: Joao Alberto de Faria
Issue created by migration from https://trac.sagemath.org/ticket/16838
The text was updated successfully, but these errors were encountered: