LP-related typos

[dimpase]

few annoying typos fixed

Depends on #16714

CC: @nathanncohen

Component: linear programming

Author: Dima Pasechnik

Branch: 96bdd0b

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/16847

[dimpase]

Commit: ed0e383

[dimpase]

Branch: public/16847

[dimpase]

Last 10 new commits:

1c5c024	Full doctest coverage
fd10630	Clean up add_constraint()
08bc41a	Allow specifying constraints via vector-valued linear functions
e7d48ef	Also document matrix * MIPVariable notation
0090edc	Improve documentation
039a835	Spelling and docstring fixes
e2ddf8c	Simplify and document how to extract coefficients
d3d0d10	Document generator syntax some more
74e38d5	typo from #16714(comment 59)
ed0e383	more typos in rst docs

[dimpase]

Dependencies: 16714

[nathanncohen]

Changed dependencies from 16714 to none

[nathanncohen]

comment:4

O_o

Is there any way to know which commits correspond to this ticket ? O_o

Nathann

[nathanncohen]

Dependencies: #16714

[dimpase]

comment:6

Replying to @nathanncohen:

O_o

Is there any way to know which commits correspond to this ticket ? O_o

the last two in the list above.
If you merge it over #16714 you will only see them, I think...

[nathanncohen]

comment:7

the last two in the list above.
If you merge it over #16714 you will only see them, I think...

Okay. Really, adding the ticket number to the commit message helps a lot in case like that. Tickets like #16722 would be very hard to review without that :-P

Nathann

[sagetrac-git]

Changed commit from ed0e383 to 96bdd0b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

96bdd0b

vi-induced typo in #16847

[dimpase]

comment:9

Replying to @nathanncohen:

the last two in the list above.
If you merge it over #16714 you will only see them, I think...

Okay. Really, adding the ticket number to the commit message helps a lot in case like that. Tickets like #16722 would be very hard to review without that :-P

OK, here is one more commit (with the ticket number).
I can in principle fix the other commit messages - should I? Or you can review like this?

[nathanncohen]

comment:11

Yoooooo !

OK, here is one more commit (with the ticket number).
I can in principle fix the other commit messages - should I? Or you can review like this?

Yes yes of course, no problem ! But why did you remove PPL and CVXOPT from this list ? Initially it was not about optional solvers only, was it ?

Nathann

[dimpase]

comment:12

Replying to @nathanncohen:

Yoooooo !

OK, here is one more commit (with the ticket number).
I can in principle fix the other commit messages - should I? Or you can review like this?

Yes yes of course, no problem ! But why did you remove PPL and CVXOPT from this list ? Initially it was not about optional solvers only, was it ?

PPL and CVXOPT are mentioned in the lines just above the one you mean, so it was purely
an unnecessary repetition, potentially confusing.

[nathanncohen]

comment:13

Oh. Right. Okay, then it's all good. Thanks !

Nathann

[nathanncohen]

Author: ​Dima Pasechnik

[nathanncohen]

Reviewer: Nathann Cohen

[vbraun]

Changed author from ​Dima Pasechnik to Dima Pasechnik

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

e42ce55

instanc/tiated...

[sagetrac-git]

Changed commit from 96bdd0b to e42ce55

[dimpase]

comment:16

just saw few more typos... please review the last commit.

[vbraun]

Changed branch from public/16847 to e42ce55

[cheuberg]

comment:19

Replying to @sagetrac-git:

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

e42ce55

instanc/tiated...

This last commit has not been merged, see the discussion at sage-devel.
I opened a new ticket for that commit: #18219.

[cheuberg]

Changed commit from e42ce55 to none

[cheuberg]

Changed branch from e42ce55 to 96bdd0b