Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radical difference families #16866

Closed
videlec opened this issue Aug 22, 2014 · 51 comments
Closed

Radical difference families #16866

videlec opened this issue Aug 22, 2014 · 51 comments
Labels
c: combinatorial designs p: major / 3 t: enhancement
Milestone
sage-6.4

Comments

@videlec
Copy link
Contributor

videlec commented Aug 22, 2014

Exhaustive search for radical difference families through dancing links.

Depends on #16863

CC: @nathanncohen

Component: combinatorial designs

Keywords: sd66

Author: Vincent Delecroix

Branch/Commit: 74c869b

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/16866
@videlec videlec added this to the sage-6.4 milestone Aug 22, 2014
@videlec
Copy link
Contributor Author

videlec commented Aug 22, 2014

Last 10 new commits:

f3f644dtrac #16763: code simplification
04936aatrac #16802: database of difference family
4bd8d69trac #16802: Review
4434d61trac #16802: review the review
33b4171trac #16863: twin prime difference set
acd60a2trac #16863: Handle all prime powers (not just primes)
5903ac6trac #16863: doc and simplification
f45b57atrac #16866: Buratti 1995 constructions
bb21dc0trac #16763: Double citation
91412d7trac #16866: merge #16763

@videlec
Copy link
Contributor Author

videlec commented Aug 22, 2014

Commit: 91412d7

@videlec
Copy link
Contributor Author

videlec commented Aug 22, 2014

Dependencies: #16863

@videlec
Copy link
Contributor Author

videlec commented Aug 22, 2014

Branch: u/vdelecroix/16866

@nathanncohen nathanncohen mannequin removed this from the sage-6.4 milestone Aug 22, 2014
@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Aug 22, 2014

comment:3

(Vincent found a more general version of this construction, and it is not worth merging this only to remove it later)

@videlec

This comment has been minimized.

Sign in to view
@videlec
Copy link
Contributor Author

videlec commented Aug 22, 2014

comment:4

I will use the ticket for the more general version...

@videlec videlec changed the title (q,4,1) and (q,5,1) difference families (Buratti 1995) Radical difference families Aug 22, 2014
@videlec videlec added this to the sage-6.4 milestone Aug 22, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7203d58trac #16866: dlx for radical difference family

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2015

Changed commit from 91412d7 to 7203d58

@videlec

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2015

Changed commit from 7203d58 to e26d574

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

e26d574trac #16866: remove trailing whitespaces

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

81fb94dtrac #16866: avoid dlx for difference_set

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2015

Changed commit from e26d574 to 81fb94d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 19, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

657244btrac #16866: remove trailing whitespaces
bee446ftrac #16866: avoid dlx for difference_set
58fed55trac #16866: formatting

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 19, 2015

Changed commit from 81fb94d to 58fed55

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4af9461Trac 16866: dlx for radical difference family

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2015

Changed commit from 721af75 to 4af9461

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 3, 2015

comment:30

Helloooo Vincent !

I added at public/16866 a commit that rewrites the documentation. I began to touch the code itself but so far I do not understand the reason behind this m=k//2, and why your set A has cardinality k/2 instead of k-1. I made that change and many doctests broke, so could you please enlighten me?

Thanks,

Nathann

P.S.: the doc's notations match the code

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

ae0c9cctrac #16866: Doc rewrite
4aa4732Trac 16866: takes care of +1/-1 in the doc
4227487remove wilson

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2015

Changed commit from 4af9461 to 4227487

@videlec
Copy link
Contributor Author

videlec commented Apr 3, 2015

comment:32

Thanks! I adopted your commit and added two:

  • one to explain in the doc the m/2
  • the other one to get rid of the wilson_XXX that can be thought as a special case of the newly created one

Vincent

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 4, 2015

comment:36

Helloooooooooooooo !

I am finally convinced by everything that was done in this patch. I only have two commits to offer at public/16866.

  1. One that makes the notations of the doc and code match
  2. One that changes print_tiling to display '.' instead of blank spaces.

You turn ;-)

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 4, 2015

Reviewer: Nathann Cohen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 4, 2015

Changed keywords from none to sd66

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

ba291f3trac #16866: Merged with rc2
13d3aadtrac #16866: Make doc and code match
ae7c4f1trac #16866: Change the output of print_tiling

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2015

Changed commit from 4227487 to ae7c4f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2015

Changed commit from ae7c4f1 to 74c869b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

74c869bTrac 16866: some typo in the doc

@videlec
Copy link
Contributor Author

videlec commented Apr 5, 2015

comment:40

I am happy with the current situation.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 5, 2015

comment:41

Making you happy is Sage's purpose.

Thanks for the branch,

Nathann

@vbraun
Copy link
Member

vbraun commented Apr 14, 2015

Changed branch from u/vdelecroix/16866 to 74c869b

@vbraun vbraun closed this as completed in af573f5 Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorial designs p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
2 participants
@vbraun @videlec