Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 520+x OA constructors #16867

Closed
nathanncohen mannequin opened this issue Aug 22, 2014 · 6 comments
Closed

Merge 520+x OA constructors #16867

nathanncohen mannequin opened this issue Aug 22, 2014 · 6 comments
Labels
c: combinatorial designs p: major / 3 t: enhancement
Milestone
sage-6.4

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Aug 22, 2014

These 3 OA constructors all do the same thing. Their doc is the same, their code is the same. Let's merge them all into one function !

Depends on #16846

CC: @videlec

Component: combinatorial designs

Author: Nathann Cohen

Branch/Commit: 28a0c1b

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/16867
@nathanncohen nathanncohen mannequin added this to the sage-6.4 milestone Aug 22, 2014
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 22, 2014

Last 10 new commits:

5b8500btrac #16864: designs/database.py: auto-generated doc index
bfbad46trac #16864: use Python string .format() + doc
3ca48dctrac #16817: OA for n=205,254,469,520,522,524,1262
f9e6569trac #16817: docfix
c92e9bftrac #16846: a difference_matrices module
fdab06etrac #16846: Remove obsolete functions
f7afe6ftrac #16846: Broken doctests
fd1bbc6trac #16846: Merge with updated #16817
c66c19btrac #16846: review
28a0c1btrac #16867: Merge 520+x OA constructors

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 22, 2014

Commit: 28a0c1b

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 22, 2014

Branch: public/16867

@nathanncohen nathanncohen mannequin added the s: needs review label Aug 22, 2014
@videlec
Copy link
Contributor

videlec commented Aug 22, 2014

comment:2

Bioutifoule!

Vincent

@videlec
Copy link
Contributor

videlec commented Aug 22, 2014

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Aug 24, 2014

Changed branch from public/16867 to 28a0c1b

@vbraun vbraun closed this as completed in 2d71636 Aug 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorial designs p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
2 participants
@vbraun @videlec