Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cython to 0.21 #16912

Closed
jdemeyer opened this issue Aug 31, 2014 · 15 comments
Closed

Upgrade Cython to 0.21 #16912

jdemeyer opened this issue Aug 31, 2014 · 15 comments

Comments

@jdemeyer
Copy link

Download this file and rename it to $SAGE_ROOT/upstream/cython-0.21.tar.gz:
http://cython.org/release/Cython-0.21.tar.gz

This is needed to fix #16113.

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/16912 @ 7abf02b

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/16912

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Sep 1, 2014

Branch: u/jdemeyer/ticket/16912

@vbraun
Copy link
Member

vbraun commented Sep 2, 2014

Commit: 91276f1

@vbraun
Copy link
Member

vbraun commented Sep 2, 2014

comment:5

If its a beta version then we shoudn't save it as cython-0.21.tar.gz. Tarball names must be unique over time, otherwise you'll have to manually delete the old cached version.


New commits:

91276f1Upgrade to Cython 0.21

@jdemeyer
Copy link
Author

jdemeyer commented Sep 2, 2014

comment:6

Replying to @vbraun:

If its a beta version then we shoudn't save it as cython-0.21.tar.gz. Tarball names must be unique over time, otherwise you'll have to manually delete the old cached version.

This ticket isn't yet needs_review (and the ticket description clearly states that it's a beta), so I don't consider that a problem. It's easier for me to simply rename the tarball than to edit build/pkgs/cython/*.

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8d99415Upgrade to Cython 0.21

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2014

Changed commit from 91276f1 to 8d99415

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2014

Changed commit from 8d99415 to 7abf02b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7abf02bUpgrade to Cython 0.21

@vbraun
Copy link
Member

vbraun commented Sep 10, 2014

comment:11

lgtm

@vbraun
Copy link
Member

vbraun commented Sep 10, 2014

Reviewer: Volker Braun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants