Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more mpn functions for bitsets #16937

Closed
jdemeyer opened this issue Sep 5, 2014 · 10 comments
Closed

Use more mpn functions for bitsets #16937

jdemeyer opened this issue Sep 5, 2014 · 10 comments
Labels
p: major / 3 t: enhancement
Milestone
sage-6.4

Comments

@jdemeyer
Copy link

jdemeyer commented Sep 5, 2014

In #13352, we use mpn_popcount for bitsets but more bitset functions could benefit from using MPIR functions.

Depends on #16583
Depends on #16910
Depends on #15946

CC: @nathanncohen @dcoudert

Component: misc

Author: Jeroen Demeyer

Branch/Commit: 6872b4a

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/16937
@jdemeyer jdemeyer added this to the sage-6.4 milestone Sep 5, 2014
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Use more mpn functions for bitsets Use more mpz or mpn functions for bitsets Sep 5, 2014
@jdemeyer
Copy link
Author

jdemeyer commented Sep 5, 2014

Dependencies: #16583, #16910, #15946

@jdemeyer
Copy link
Author

jdemeyer commented Sep 5, 2014

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

jdemeyer commented Sep 5, 2014

Branch: u/jdemeyer/ticket/16937

@jdemeyer
Copy link
Author

jdemeyer commented Sep 5, 2014

Commit: 8717825

@jdemeyer
Copy link
Author

jdemeyer commented Sep 5, 2014

Last 10 new commits:

14e730eMerge with 6.4.beta1
18a4842trac #16583, oops, correcting wrong merge
c416feeRemove stuff which is not needed
b3d6aa2Further cleanup
20c767cFix include of fmpq_poly.pxi in Cython doctest
6fc03e3Get rid of mpz_t_offset hacks
4a5d820Merge branch 'ticket/16910' into HEAD
d76f8e7Fix mpz_t, mpq_t, mpf_t declarations
a52cff2Use mpz_srcptr for padics pow_computer
8717825Use mpn functions for bitsets

@jdemeyer jdemeyer changed the title Use more mpz or mpn functions for bitsets Use more mpn functions for bitsets Sep 5, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

6872b4aCast size to when comparing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2014

Changed commit from 8717825 to 6872b4a

@vbraun
Copy link
Member

vbraun commented Sep 23, 2014

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Sep 25, 2014

Changed branch from u/jdemeyer/ticket/16937 to 6872b4a

@vbraun vbraun closed this as completed in 18cfdc1 Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer