Orbit Structure for Affine Morphisms

[sagetrac-gjorgenson]

Orbit structure is a function for projective morphisms returning the pre-period and period of a point by the map in projective space. The same function can be defined for affine morphisms with little change.

Used the same function code but replaced the examples with those suited for affine space.

sage: A.<x,y,z> = AffineSpace(GF(49, 't'),3)
sage: H = Hom(A,A)
sage: f = H([x^2 - z, x - y + z, y^2 - x^2])
sage: f.orbit_structure(A(1,1,2))
[7, 6]

CC: @bhutz

Component: algebraic geometry

Author: Grayson Jorgenson

Branch/Commit: f603579

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/16960

[sagetrac-gjorgenson]

Branch: u/gjorgenson/ticket/16960

[sagetrac-gjorgenson]

Commit: 6d95883

[sagetrac-gjorgenson]

New commits:

6d95883

Minor addition to affine morhpisms.

[bhutz]

Reviewer: Ben Hutz

[bhutz]

comment:3

Just some minor things. The functionality seems fine. Also put your full name in Author.

function is spelled wrong in comments. Actually the affine_point version has a number of typos as does the projective_point/projective_morphism versions. This is perhaps a reasonable place to fix all those typos.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cc902e7

Typo fixes in the orbit_structure function.

[sagetrac-git]

Changed commit from 6d95883 to cc902e7

[sagetrac-gjorgenson]

Changed author from gjorgenson to Grayson Jorgenson

[sagetrac-gjorgenson]

comment:6

I changed all the typos I could find. Are there any others that should be addressed?

[bhutz]

comment:7

There are some '=' instead of ' = ' in a couple of the examples.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c92eb76

Minor typo fixes in orbit_structure.

[sagetrac-git]

Changed commit from cc902e7 to c92eb76

[bhutz]

Changed branch from u/gjorgenson/ticket/16960 to u/bhutz/ticket/16960

[bhutz]

Changed commit from c92eb76 to f603579

[bhutz]

comment:10

Looks good. I just removed a little bit of trailing white space.

---

New commits:

f603579

rremoved trailing whitespace

[vbraun]

Changed branch from u/bhutz/ticket/16960 to f603579