PermutationGroup.minimal_generating_set (from GAP)

[nathanncohen]

Just the boring ol' wrapping.

Nathann

CC: @dimpase

Component: group theory

Author: Nathann Cohen

Branch/Commit: 4c583ea

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/17007

[nathanncohen]

Branch: u/ncohen/17007

[sagetrac-git]

Commit: 7b2f281

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7b2f281

trac #17007: PermutationGroup.minimal_generating_set (from GAP)

[dimpase]

comment:3

You are not the first to need to convert GAP permutations into Sage ones. There is sage.groups.perm_gps.permgroup.from_gap_list() that does the dirty part, just call it...

(dunno why this function is not exported, perhaps it should be, then it can be easy to find...)

[nathanncohen]

comment:4

Well perhaps, but is miserably fails when the group is not defined over integers.

sage: g=PermutationGroup(["(1,2,3)(4,5,6)","(1,2,3,4,5,6)"])                               
sage: sage.groups.perm_gps.permgroup.from_gap_list(g,str(g._gap_().MinimalGeneratingSet()))
[(2,5)(3,6), (1,5,3,4,2,6)]
sage: g=PermutationGroup([('a','b','c')])                                                  
sage: sage.groups.perm_gps.permgroup.from_gap_list(g,str(g._gap_().MinimalGeneratingSet()))
...
ValueError: Invalid permutation vector:  (1,2,3) 

[nathanncohen]

comment:5

Yo !

You are not the first to need to convert GAP permutations into Sage ones. There is sage.groups.perm_gps.permgroup.from_gap_list() that does the dirty part, just call it...

This function was so useful that I overwrote it with my code. Thanks :-P

Nathann

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

44ba55c

trac #17007: PermutationGroup.minimal_generating_set (from GAP)

[sagetrac-git]

Changed commit from 7b2f281 to 44ba55c

[sagetrac-git]

Changed commit from 44ba55c to 4c583ea

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4c583ea

trac #17007: PermutationGroup.minimal_generating_set (from GAP)

[dimpase]

comment:8

LGTM. Hopefully the long tests pass everywhere after this change.

[vbraun]

comment:9

Reviewer name

[nathanncohen]

Reviewer: Dima Pasechnik

[vbraun]

Changed branch from u/ncohen/17007 to 4c583ea