Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some old scipy-related weirdness in functions/special.py #17011

Closed
dimpase opened this issue Sep 20, 2014 · 7 comments
Closed

fix some old scipy-related weirdness in functions/special.py #17011

dimpase opened this issue Sep 20, 2014 · 7 comments
Labels
c: numerical p: minor / 4 t: bug
Milestone
sage-6.4

Comments

@dimpase
Copy link
Member

dimpase commented Sep 20, 2014

In couple of places the conversion from scipy complex number to Sage is done via strings, which is probably some old relic going back to 2008 or so.

As well, the type of the returned number is default Sage's data, rather than C/RDF, as it should be, to avoid confusion about precision of these computations, cf e.g. http://ask.sagemath.org/question/24163/why-does-sage-offer-unusable-scipy

Component: numerical

Author: Dima Pasechnik

Branch/Commit: b690e98

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/17011
@dimpase dimpase added this to the sage-6.4 milestone Sep 20, 2014
@dimpase
Copy link
Member Author

dimpase commented Sep 20, 2014

Branch: u/dimpase/fix_some_old_scipy_related_weirdness_in_function_py

@dimpase

This comment has been minimized.

Sign in to view
@dimpase
Copy link
Member Author

dimpase commented Sep 20, 2014

Commit: b690e98

@dimpase dimpase changed the title fix some old scipy-related weirdness in function.py fix some old scipy-related weirdness in functions/special.py Sep 20, 2014
@vbraun
Copy link
Member

vbraun commented Sep 21, 2014

comment:4

lgtm

@vbraun
Copy link
Member

vbraun commented Sep 21, 2014

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Sep 21, 2014

Author: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Sep 25, 2014

Changed branch from u/dimpase/fix_some_old_scipy_related_weirdness_in_function_py to b690e98

@vbraun vbraun closed this as completed in 135fded Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: numerical p: minor / 4 t: bug
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
2 participants
@vbraun @dimpase