Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace _DivPolyContext by _multiply_point #1704

Closed
sagetrac-dmharvey mannequin opened this issue Jan 6, 2008 · 3 comments
Closed

replace _DivPolyContext by _multiply_point #1704

sagetrac-dmharvey mannequin opened this issue Jan 6, 2008 · 3 comments
Assignees
@williamstein
Labels
c: algebraic geometry p: major / 3 t: enhancement
Milestone
sage-2.10.1

Comments

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Jan 6, 2008

This patch replaces the _DivPolyContext class with a new function _multiply_point. The main downside of the original _DivPolyContext is that it's very recursive, and I started overflowing python's stack for some large problems I needed to play with. The new function is not recursive, and also turns out to be slightly faster.

Component: algebraic geometry

Issue created by migration from https://trac.sagemath.org/ticket/1704
@sagetrac-dmharvey sagetrac-dmharvey mannequin added this to the sage-2.10.1 milestone Jan 6, 2008
@sagetrac-dmharvey
Copy link
Mannequin Author

sagetrac-dmharvey mannequin commented Jan 6, 2008

Attachment: multiply_point.hg.gz

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jan 20, 2008

comment:1

I can't speak to mathematical correctness, but the patch looks good to me. Apply.

@ncalexan ncalexan mannequin added the s: positive review label Jan 20, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 21, 2008

comment:3

Merged in Sage 2.10.1.alpha1

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 21, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: algebraic geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-2.10.1
Development

No branches or pull requests
1 participant
@williamstein