Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finite poset, directed_subsets() doesn't check for argument #17046

Closed
jm58660 mannequin opened this issue Sep 26, 2014 · 10 comments
Closed

Finite poset, directed_subsets() doesn't check for argument #17046

jm58660 mannequin opened this issue Sep 26, 2014 · 10 comments
Labels
c: combinatorics r: duplicate t: bug

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 26, 2014 

Poset({0:[1]}).directed_subsets('cat-says-meow')

does not give error message. It should accept only 'up' and 'down'.

Depends on #17045

Component: combinatorics

Author: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/17046
@jm58660 jm58660 mannequin added this to the sage-6.4 milestone Sep 26, 2014
@jm58660 jm58660 mannequin added c: combinatorics labels Sep 26, 2014
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 26, 2014

Branch: u/jmantysalo/finite_poset__directed_subsets___doesn_t_check_for_argument

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 26, 2014

Commit: a401c7f

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 26, 2014

New commits:

a401c7fAdded check: direction must be 'up' or 'down'.

@jm58660 jm58660 mannequin added the s: needs review label Sep 26, 2014
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 26, 2014

Merged: #17045

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 26, 2014

comment:3

Merged this to #17045 as asked by ncohen. This one can be closed.

@jm58660 jm58660 mannequin removed this from the sage-6.4 milestone Sep 26, 2014
@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 26, 2014

comment:4

wontfix -> positive review

@jdemeyer
Copy link

jdemeyer commented Oct 1, 2014

Changed commit from a401c7f to none

@jdemeyer
Copy link

jdemeyer commented Oct 1, 2014

Changed branch from u/jmantysalo/finite_poset__directed_subsets___doesn_t_check_for_argument to none

@jdemeyer
Copy link

jdemeyer commented Oct 1, 2014

Dependencies: #17045

@jdemeyer
Copy link

jdemeyer commented Oct 1, 2014

Changed merged from #17045 to none

@vbraun vbraun closed this as completed Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics r: duplicate t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer