Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show() does not check for figsize value #17057

Closed
jm58660 mannequin opened this issue Sep 27, 2014 · 3 comments
Closed

show() does not check for figsize value #17057

jm58660 mannequin opened this issue Sep 27, 2014 · 3 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 27, 2014

For example Poset({0:[1]}).show(figsize=0) complains about singular matrix, and also figsize='cat-says-meow' is not detected as it should. And more, figsize=32767 should not answer "width and height must each be below 32768".

Component: graphics

Reviewer: Karl-Dieter Crisman, ​Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/17057

@jm58660 jm58660 mannequin added this to the sage-6.4 milestone Sep 27, 2014
@jm58660 jm58660 mannequin added c: graphics labels Sep 27, 2014
@kcrisman
Copy link
Member

comment:1

Take a look at #5956 (presumably will appear in the next beta, isn't in 6.5.beta0). I think that should catch the string problem and zero problem. We could conceivably add even more tests for those.

The other problem is user error, in some sense, now that we document what that means, but we could try to catch that as well.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 21, 2014

comment:2

This is fine for me. I'll mark this as duplicate/wontfix. (So please click to positive review.)

@jm58660 jm58660 mannequin removed this from the sage-6.4 milestone Nov 21, 2014
@jm58660 jm58660 mannequin added the s: needs review label Nov 21, 2014
@kcrisman
Copy link
Member

Reviewer: Karl-Dieter Crisman, ​Jori Mäntysalo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants