Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an optional doctest output after #16746 #17062

Closed
JohnCremona opened this issue Sep 28, 2014 · 6 comments
Closed

Fix an optional doctest output after #16746 #17062

JohnCremona opened this issue Sep 28, 2014 · 6 comments

Comments

@JohnCremona
Copy link
Member

After #16746, output of dicts is sorted by index, and this results in one test in src/doc/en/bordeaux_2008/elliptic_curves.rst failing when the optional database_cremona_ellcurve database is installed:

sage: C = CremonaDatabase()
sage: C[37]
{'allbsd': {'a1': [1,
   5.98691729246392,
   0.305999773834052,
   0.0511114082399688,
   1.0],
...

is what comes out, since the field with key 'allbsd' which only exists in the optional larger database comes before key 'allcurves' which is in the standard version. I propose replacing the test with

sage: C = CremonaDatabase()
sage: C[37]['allcurves']
{'a1': [[0, 0, 1, -1, 0], 1, 1],
 'b1': [[0, 1, 1, -23, -50], 0, 3],
 'b2': [[0, 1, 1, -1873, -31833], 0, 1],
 'b3': [[0, 1, 1, -3, 1], 0, 3]}

and will make this change soon.

Component: packages: optional

Author: John Cremona

Branch/Commit: 582876c

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/17062

@JohnCremona
Copy link
Member Author

Branch: u/cremona/ticket/17602

@JohnCremona
Copy link
Member Author

Commit: 582876c

@JohnCremona
Copy link
Member Author

New commits:

582876c#17602 doctest output fix

@JohnCremona
Copy link
Member Author

Changed branch from u/cremona/ticket/17602 to u/cremona/ticket/17062

@vbraun
Copy link
Member

vbraun commented Sep 28, 2014

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Sep 29, 2014

Changed branch from u/cremona/ticket/17062 to 582876c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants