Fix numerical noise after #16858

[jdemeyer]

Component: doctest coverage

Author: Jeroen Demeyer

Branch/Commit: 23c88bc

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/17063

[jdemeyer]

Author: Jeroen Demeyer

[jdemeyer]

Branch: u/jdemeyer/ticket/17063

[fchapoton]

comment:3

Well, this looks good to me.

But maybe there is something subtle to check ? on different architectures, etc ?

The buildbot is almost happy, but protests for some other reasons..

---

New commits:

23c88bc

Fix tolerances

[fchapoton]

Commit: 23c88bc

[jdemeyer]

comment:4

Replying to @fchapoton:

Well, this looks good to me.

Meaning positive_review?

But maybe there is something subtle to check ? on different architectures, etc ?

Of course there is. There are lots of different architectures. However, this ticket does not have to fix all doctests on all possible architectures.

The buildbot is almost happy, but protests for some other reasons..

The buildbot is broken, you can ignore those failures.

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:5

I think this is good to go, because this only let the precision be slightly lower than before. So it can not introduce any new failing doctest, in principle.

Am I correct to say that this is in particular needed to cure some of the buildbot failures ?

Let me give a positive review, even if the blocker status is rather worrying to me. I hope I did not miss the point.

[jdemeyer]

comment:6

Replying to @fchapoton:

Am I correct to say that this is in particular needed to cure some of the buildbot failures ?

Not buildbot failures, but reports from other people on the sage-release mailing list.

Let me give a positive review, even if the blocker status is rather worrying to me.

The "blocker" priority shouldn't matter for reviewing the ticket. "blocker" means that Sage 6.4 must not be released before this issue is fixed, it doesn't imply that the issue is particularly deep or difficult.

[vbraun]

Changed branch from u/jdemeyer/ticket/17063 to 23c88bc