Fix height_difference_bound to work over Number Fields

[sagetrac-jdefaria]

After checking the math, saw that there is no reason to restrict to QQ or ZZ only, fixing checks at start to reflect this.

Component: algebraic geometry

Author: Joao Alberto de Faria

Branch: 0f9a1f3

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/17082

[sagetrac-jdefaria]

Branch: u/jdefaria/ticket/17082

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a524288	Adapted code to not have to check for numerator
f64e556	Deleted lines used for testing

[sagetrac-git]

Commit: f64e556

[bhutz]

comment:4

This fails doc tests ('Not Implemented Error' spelled wrong) and needs a numberfield example

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

98959fb

17082 - fixed error checks

[sagetrac-git]

Changed commit from f64e556 to 98959fb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0934909

17082- added num field example

[sagetrac-git]

Changed commit from 98959fb to 0934909

[bhutz]

comment:8

Well, a couple things here. This passes all the long tests, and the functionality change seems ok. However, there are two things that should be fixed.

• There is an indentation issue with the new example you added.

• you seems to restrict to number fields or ZZ. If it is ZZ the code changes the ring to QQ so that .lift() works. Why can't you do this for any number field ring (change to its field of fractions)?

[bhutz]

Reviewer: Ben Hutz

[sagetrac-git]

Changed commit from 0934909 to 4102df2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4102df2

Changed from ZZ to number field rings

[sagetrac-jdefaria]

comment:10

I opened the documentation, didn't see any problems there, everything else is fixed, needs review

[sagetrac-git]

Changed commit from 4102df2 to 68978c2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

68978c2

Fixed small whitespace issues and condensed code

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0f9a1f3

More Typos and whitespace errors

[sagetrac-git]

Changed commit from 68978c2 to 0f9a1f3

[vbraun]

Changed branch from u/jdefaria/ticket/17082 to 0f9a1f3

[jdemeyer]

Changed commit from 0f9a1f3 to none

[jdemeyer]

Changed author from Joao de Faria to Joao Alberto de Faria