New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Sym and NSym functionality #17125
Comments
comment:2
I've briefly looked over the branch changes but haven't tried out your code yet. I'm always intimidated by your patches because they are never minor. :) This looks good though. Before even testing anything, the GR symmetric functions and the CSW quasi-symmetric functions need INPUT: OUTPUT: sections in the documentation. I kind of found it strange that you put in the functionality to compute |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Thanks, I spent so long without programming that I forgot about these conventions. Why an extra syntax for the one-row partitions? Just because they're defined first in Gessel-Reutenauer (they are also characters of the free Lie algebra as S_n-representations, I believe). |
comment:5
Replying to @darijgr:
I somewhat feel that this can muddy things because you really want partitions. Although if you do want the extra semantic (I don't have a strong opinion), then I think you should just check |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Thanks, I forgot about the right way to get these standard rings too. I thought people would want a simpler syntax for the simple cases. I am fine with or without it just as much. New commits:
|
Reviewer: Travis Scrimshaw, Mike Zabrocki |
Changed branch from u/darij/moresym to public/combinat/moresym-17125 |
comment:8
Some review changes. I also marked some tests as long (and made some of them correctly marked). If you're happy with my changes, then it's a positive review. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Travis: thank you for the review! (The last change was discussed on Skype.) |
Changed branch from public/combinat/moresym-17125 to |
CC: @nthiery @tscrim @sagetrac-sage-combinat @zabrocki
Component: combinatorics
Keywords: symmetric functions, noncommutative symmetric functions
Author: Darij Grinberg
Branch/Commit:
6c6e606
Reviewer: Travis Scrimshaw, Mike Zabrocki
Issue created by migration from https://trac.sagemath.org/ticket/17125
The text was updated successfully, but these errors were encountered: