Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Cython to 0.21.1 #17195

Closed
jdemeyer opened this issue Oct 22, 2014 · 10 comments
Closed

Upgrade Cython to 0.21.1 #17195

jdemeyer opened this issue Oct 22, 2014 · 10 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-6.4

Comments

@jdemeyer
Copy link

This should be an easy upgrade.

Main useful feature for Sage: declarations of the PySlice API.

Rename the upstream tarball http://cython.org/release/Cython-0.21.1.tar.gz to $SAGE_ROOT/upstream/cython-0.21.1.tar.gz

CC: @robertwb

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 8c69daf

Reviewer: Robert Bradshaw

Issue created by migration from https://trac.sagemath.org/ticket/17195
@jdemeyer jdemeyer added this to the sage-6.4 milestone Oct 22, 2014
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/17195

@jdemeyer
Copy link
Author

New commits:

8c69dafUpgrade Cython to 0.21.1

@jdemeyer
Copy link
Author

Commit: 8c69daf

@robertwb
Copy link
Contributor

comment:5

The changes look fine to me, so positive review pending a clean build and tests passing.

@jdemeyer
Copy link
Author

Reviewer: Robert Bradshaw

@jdemeyer
Copy link
Author

comment:6

At least on my machine, it builds fine and passes all tests.

@vbraun
Copy link
Member

vbraun commented Oct 23, 2014

comment:7

I would really appreciate if the upstream tarball instructions don't include manual steps. Just give me a link to a file next time.

@vbraun
Copy link
Member

vbraun commented Oct 24, 2014

Changed branch from u/jdemeyer/ticket/17195 to 8c69daf

@vbraun vbraun closed this as completed in 7f934ea Oct 24, 2014
@simon-king-jena simon-king-jena mentioned this issue Dec 13, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
3 participants
@robertwb @vbraun @jdemeyer