Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cmp parameter from L.sort() in src/sage/tests/french_book/programmation_doctest.py #17200

Closed
a-andre opened this issue Oct 22, 2014 · 7 comments
Closed

Remove cmp parameter from L.sort() in src/sage/tests/french_book/programmation_doctest.py #17200

a-andre opened this issue Oct 22, 2014 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.3

Comments

@a-andre
Copy link

a-andre commented Oct 22, 2014

In Python 3 cmp parameter of L.sort() is gone. See #16536.
Line 511 in programmation_doctest.py is affected

sage: L.sort (cmp = alpha) ; L

Remove cmp parameter and use key parameter instead.

CC: @zimmermann6

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 8a0eb18

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/17200
@a-andre a-andre added this to the sage-6.4 milestone Oct 22, 2014
@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:2

just enough to make sure that the test will be skipped with python3

New commits:

8a0eb18trac 17200 adding an optional python2 to a test in French book

@fchapoton
Copy link
Contributor

Branch: public/17200

@fchapoton
Copy link
Contributor

Commit: 8a0eb18

@fchapoton fchapoton modified the milestones: sage-6.4, sage-7.3 Jul 6, 2016
@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jul 6, 2016

comment:4

OK.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jul 6, 2016

Reviewer: Jori Mäntysalo

@vbraun
Copy link
Member

vbraun commented Jul 7, 2016

Changed branch from public/17200 to 8a0eb18

@vbraun vbraun closed this as completed in bef1098 Jul 7, 2016
@wluebbe wluebbe mannequin mentioned this issue Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @a-andre