Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a doctest for closed ticket #8005 #17244

Closed
orlitzky opened this issue Oct 28, 2014 · 7 comments
Closed

Add a doctest for closed ticket #8005 #17244

orlitzky opened this issue Oct 28, 2014 · 7 comments

Comments

@orlitzky
Copy link
Contributor

The issue from #8005 was fixed by another ticket, #9138. I've added a doctest for it and cleaned up a little.

Component: algebra

Author: Michael Orlitzky

Branch/Commit: 7232cd5

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/17244

@orlitzky orlitzky added this to the sage-6.4 milestone Oct 28, 2014
@orlitzky
Copy link
Contributor Author

Commit: 7232cd5

@orlitzky
Copy link
Contributor Author

Branch: u/mjo/ticket/17244

@orlitzky
Copy link
Contributor Author

New commits:

7232cd5Trac #17244: Add a doctest for the example on trac #8005.

@jdemeyer
Copy link

comment:2

Normally there should be spaces around the = like

R.<x,y> = F[]

but positive review anyway.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@orlitzky
Copy link
Contributor Author

comment:3

Replying to @jdemeyer:

Normally there should be spaces around the = like

R.<x,y> = F[]

but positive review anyway.

Ah, I copy/pasted from the description in #8005 and didn't catch it, sorry. Thanks for the review.

@vbraun
Copy link
Member

vbraun commented Oct 29, 2014

Changed branch from u/mjo/ticket/17244 to 7232cd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants