cleanup of several minor points in sage/combinat

[fchapoton]

This aims to clean up three things:

• deprecated use of raise
• deprecated use of has_key
• pep8 error E222

in the combinat part of sage only

See https://groups.google.com/forum/#!topic/sage-combinat-devel/f7SE-5BpRZg

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 048ba5b

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/17270

[fchapoton]

New commits:

048ba5b

trac 172XX : cleanup of pep8 E222 and W601 and raise in src/sage/combinat

[fchapoton]

Commit: 048ba5b

[fchapoton]

Branch: u/chapoton/17270

[nathanncohen]

Reviewer: Nathann Cohen

[nathanncohen]

comment:2

Hello !

Well, you do not do much harm with your pep8 patches but honestly a large part of it is just intolerance.. Like replacing p[i-1] with p[i - 1] :-P

Also, I personally prefer

if <condition>:
   return <thing>
else:
    return <another thing>

to

if <condition>
   return <thing>
return <another thing>

And it would be cool to respect other people's writing style sooo... Well, write code however you like, but please don't change the code only because it is not your style.

Nathann

[vbraun]

Changed branch from u/chapoton/17270 to 048ba5b